This is a port to D8 of code cleanup, following up the comment from #2159347-86: Aggregation not working simple test case.

CommentFileSizeAuthor
#1 code_cleanup_in_views-2444897-1.patch639 bytesclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented
Assigned: Unassigned » dawehner
Status: Active » Needs review
FileSize
code_cleanup_in_views-2444897-1.patch639 bytes

Patch. @dawehner I'm assigning this to you for RTBC.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Thanks a ton.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Making D8 and D7 Views code the same helps with maintenance and reduces fragility, so is good to go during beta.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed cd58cb9 on 8.0.x 
    Issue #2444897 by claudiu.cristea: Code cleanup in Views Sql query...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.