Closed (fixed)
Project:
Composer Manager
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
2 Mar 2015 at 16:51 UTC
Updated:
30 Oct 2015 at 23:04 UTC
Jump to comment: Most recent
Comments
Comment #1
dstolComment #2
bojanz commentedArchitecturally I think 8.x-1.x could benefit the quickest from stealing a few tricks from wikimedia/composer-merge-plugin (registering a plugin instead of having custom drupal-* commands, resolving duplicates).
Probably not something I'll have time to explore right now, since the current solution works (and the fact that composer.json is actually overwritten instead of dynamically modified means that it's very debuggable).
Comment #3
MixologicWorth noting that core itself may leverage the composer-merge plugin. See attached issue
Comment #4
MixologicAnd by attached issue I mean this one:
Comment #5
bojanz commentedThe core patch has landed.
I've committed the first two cleanups based on that:
http://cgit.drupalcode.org/composer_manager/commit/?id=138b22f
http://cgit.drupalcode.org/composer_manager/commit/?id=4a57f13
In total 500 lines of code removed.
This issue can now be attempted (adding modules to the replace and merge fields instead of adding their dependencies to require and require-dev).
Comment #7
bojanz commentedThat was easy :)