Remove usage and the function drupal_theme_access().

drupal_theme_access() is still there in line in system.module

core/includes/theme.inc:88:function drupal_theme_access($theme) {
core/modules/system/src/Tests/Theme/ThemeTest.php:211:    // Check if drupal_theme_access() retrieves enabled themes properly from
core/modules/system/src/Tests/Theme/ThemeTest.php:213:    $this->assertTrue(drupal_theme_access('test_theme'), 'Installed theme detected');
core/modules/system/src/Tests/Theme/ThemeTest.php:215:    $this->assertTrue(drupal_theme_access('test_theme'), 'Enabled theme detected');
core/modules/system/system.module:321:  return \Drupal::currentUser()->hasPermission('administer themes') && drupal_theme_access($theme);
bash-3.2$

This issue is to remove the usage of the function and the function.

CommentFileSizeAuthor
#3 2443817-drupal_theme_access-3.patch2.65 KBandypost
#3 interdiff.txt1.76 KBandypost
#1 remove-use-function-drupal_theme_access-2443817-1.patch1.53 KBa_thakur
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

a_thakur’s picture

a_thakur CreditAttribution: a_thakur commented
Status: Active » Needs review
FileSize
remove-use-function-drupal_theme_access-2443817-1.patch1.53 KB

Please find the patch which removes the usage of the function and the function.

Status: Needs review » Needs work

The last submitted patch, 1: remove-use-function-drupal_theme_access-2443817-1.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.76 KB
2443817-drupal_theme_access-3.patch2.65 KB

Fix test, also removed unused _system_themes_access()

a_thakur’s picture

a_thakur CreditAttribution: a_thakur commented
Assigned: a_thakur » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good, changing to RTBC.

Also link added to relevant change record: https://www.drupal.org/node/2150863

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed e748ee2 on 8.0.x 
    Issue #2443817 by andypost, a_thakur: Remove usage and the function...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.