Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"

Remove functions:

  • element_property()
  • element_properties()
  • element_child()
  • element_children()
  • element_get_visible_children()
  • element_set_attributes()
bash-3.2$ grep element_set_attributes -nr *
core/includes/common.inc:1462:function element_set_attributes(array &$element, array $map) {
bash-3.2$
CommentFileSizeAuthor
#18 remove_element_from-2443805-18.patch3.03 KBjeroent
#14 remove-element-2443805-7.patch4.11 KBa_thakur
#6 remove_element-2443805-6.patch3.96 KBa_thakur
#2 remove-element_set_attributes-2443805-1.patch1.15 KBa_thakur

Comments

a_thakur’s picture

a_thakur commented
Status: Needs review » Active
a_thakur’s picture

a_thakur commented
Status: Active » Needs review
StatusFileSize
new remove-element_set_attributes-2443805-1.patch1.15 KB

Please find the patch which removes the function.

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Please attached the relevant change record.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Also please merge #2443793: Remove element_property() from common.inc and #2443807: Remove element_get_visible_children() from common.inc and remove the rest of the element_* from common.inc in this issue.

a_thakur’s picture

a_thakur commented
StatusFileSize
new remove_element-2443805-6.patch3.96 KB

Patch attached.

a_thakur’s picture

a_thakur commented
Status: Needs work » Needs review
a_thakur’s picture

a_thakur commented

Link added to relevant change records as well: https://www.drupal.org/node/2173683

Status: Needs review » Needs work

The last submitted patch, 6: remove_element-2443805-6.patch, failed testing.

a_thakur’s picture

a_thakur commented
Title: Remove element_set_attributes() from common.inc » Remove element_* from common.inc
Status: Needs work » Needs review

daffie queued 6: remove_element-2443805-6.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 6: remove_element-2443805-6.patch, failed testing.

daffie’s picture

daffie commented
Status: Needs work » Postponed

Postponed on #2226621: Remove usage of element_info(), element_child() and element_children(). Deprecate element_info_property()..

a_thakur’s picture

a_thakur commented
Status: Postponed » Needs review
StatusFileSize
new remove-element-2443805-7.patch4.11 KB

Usage have been fixed in https://www.drupal.org/node/2226621, please find the patch to delete the functions.

a_thakur’s picture

a_thakur commented
Assigned: a_thakur » Unassigned
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Patch looks good. All tests pass.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Status: Reviewed & tested by the community » Needs work

element_info and element_info_property should not be removed since they were not deprecated in time (see the comment)

Beta evaluation on the meta, #2205673: [META] Remove all @deprecated functions marked "remove before 8.0"

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
Issue tags: +drupaldevdays
StatusFileSize
new remove_element_from-2443805-18.patch3.03 KB

Created new patch that removes the following functions:

  • element_property()
  • element_properties()
  • element_child()
  • element_children()
  • element_get_visible_children()
  • element_set_attributes()
andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Parent issue: » #2205673: [META] Remove all @deprecated functions marked "remove before 8.0"
Related issues: +#2443793: Remove element_property() from common.inc
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Does in fact remove:

  • element_property()
  • element_properties()
  • element_child()
  • element_children()
  • element_get_visible_children()
  • element_set_attributes()

Also verified that those functions are marked for deprecation in 8.0.0.

Thus: +1 on RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed b9114f6 on 8.0.x 
    Issue #2443805 by a_thakur, JeroenT: Remove element_* from common.inc

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.