Problem/Motivation

AreaTitleWebTest fails currently with PostgreSQL as database backend.

Proposed resolution

Identify and fix the failing tests.

Remaining tasks

Write patch.

User interface changes

None.

API changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bzrudi71’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
2.22 KB

Moving over existing patch from parent issue. Please see comments #3 - #7. Credits to @xjm please.

dawehner’s picture

+++ b/core/modules/views/src/Tests/Handler/AreaTitleWebTest.php
@@ -41,23 +41,48 @@ public function testTitleText() {
-      'value' => ['value' => '042118160112'],
...
+      'value' => 'Euler',

Puh, this is a hard. Replacing that nice number with another cool string.

daffie’s picture

Status: Needs review » Needs work

It all looks good to me.
I can confirm that the test fails for postgreSQL and with the patch the test passes for postgreSQL.

I have only one problem with the patch:

+++ b/core/modules/views/src/Tests/Handler/AreaTitleWebTest.php
@@ -41,23 +41,48 @@ public function testTitleText() {
     $this->drupalGet('test-area-title');
     $this->assertTitle('test_title_header | Drupal');
...
+    $this->drupalGet('test-area-title');
+    $this->assertTitle('test_title_header | Drupal');

These lines are now double. If this is necessary, can you explain to me why?

bzrudi71’s picture

Status: Needs work » Needs review
FileSize
2.19 KB
595 bytes

Yes, the lines seem doubled by mistake. Patch attached.

daffie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

bzrudi71’s picture

Thanks for review daffie!
Whoever this commits, credits to @xjm please for the initial patch!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 287c6be on 8.0.x
    Issue #2443691 by bzrudi71, xjm: PostgreSQL: Fix views\Tests\Handler\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

The double title assert was to confirm that the title was there, then gone, then back. It was duplicated on purpose. :P

xjm’s picture

+++ b/core/modules/views/src/Tests/Handler/AreaTitleWebTest.php
@@ -38,26 +38,48 @@ protected function setUp() {
+    // Confirm that the view has the normal title before making the view return
+    // no result.

As it indicates here.

xjm’s picture

...Oh. But it was not supposed to be duplicated twice at the beginning. Never mind. ;)