Problem/Motivation

AreaTitleWebTest fails currently with PostgreSQL as database backend.

Proposed resolution

Identify and fix the failing tests.

Remaining tasks

Write patch.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#4 interdiff.txt595 bytesbzrudi71
#4 vdc-postgres-2443691-4.patch2.19 KBbzrudi71
#1 vdc-postgres-2443691-1.patch2.22 KBbzrudi71

Comments

bzrudi71’s picture

bzrudi71 commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new vdc-postgres-2443691-1.patch2.22 KB

Moving over existing patch from parent issue. Please see comments #3 - #7. Credits to @xjm please.

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/views/src/Tests/Handler/AreaTitleWebTest.php
@@ -41,23 +41,48 @@ public function testTitleText() {
-      'value' => ['value' => '042118160112'],
...
+      'value' => 'Euler',

Puh, this is a hard. Replacing that nice number with another cool string.

daffie’s picture

daffie commented
Status: Needs review » Needs work

It all looks good to me.
I can confirm that the test fails for postgreSQL and with the patch the test passes for postgreSQL.

I have only one problem with the patch:

+++ b/core/modules/views/src/Tests/Handler/AreaTitleWebTest.php
@@ -41,23 +41,48 @@ public function testTitleText() {
     $this->drupalGet('test-area-title');
     $this->assertTitle('test_title_header | Drupal');
...
+    $this->drupalGet('test-area-title');
+    $this->assertTitle('test_title_header | Drupal');

These lines are now double. If this is necessary, can you explain to me why?

bzrudi71’s picture

bzrudi71 commented
Status: Needs work » Needs review
StatusFileSize
new vdc-postgres-2443691-4.patch2.19 KB
new interdiff.txt595 bytes

Yes, the lines seem doubled by mistake. Patch attached.

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

bzrudi71’s picture

bzrudi71 commented

Thanks for review daffie!
Whoever this commits, credits to @xjm please for the initial patch!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 287c6be on 8.0.x 
    Issue #2443691 by bzrudi71, xjm: PostgreSQL: Fix views\Tests\Handler\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented

The double title assert was to confirm that the title was there, then gone, then back. It was duplicated on purpose. :P

xjm’s picture

xjm
she/her
Primary language English
commented 
+++ b/core/modules/views/src/Tests/Handler/AreaTitleWebTest.php
@@ -38,26 +38,48 @@ protected function setUp() {
+    // Confirm that the view has the normal title before making the view return
+    // no result.

As it indicates here.

xjm’s picture

xjm
she/her
Primary language English
commented

...Oh. But it was not supposed to be duplicated twice at the beginning. Never mind. ;)