Problem/Motivation

NodeTranslationUITest fails currently with PostgreSQL as database backend.

Proposed resolution

Identify and fix the failing tests.

Remaining tasks

Write patch.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#1 node_translation_ui.patch882 bytesbzrudi71

Comments

bzrudi71’s picture

bzrudi71 commented
Status: Active » Needs review
StatusFileSize
new node_translation_ui.patch882 bytes

Just uploading available patch from #2356987: PostgreSQL: Fix tests in node test group. All credits to @jaredsmith please. (Please see #4 in the parent issue)

bzrudi71’s picture

bzrudi71 commented
Status: Needs review » Reviewed & tested by the community

This is the right way of doing it in PostgreSQL. For reference, here is the exception message:

Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42703]: Undefined column: 7 ERROR: column "count" does not exist LINE 1: ..._data WHERE type <> 'article' GROUP BY nid HAVING count >= 2 ^: SELECT nid, count(nid) AS count FROM {node_field_data} WHERE type <> :type GROUP BY nid HAVING count >= 2; Array ( [:type] => article ) in Drupal\node\Tests\NodeTranslationUITest->testDisabledBundle() (line 212 of /opt/local/apache2/htdocs/drupal8/core/modules/node/src/Tests/NodeTranslationUITest.php).

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs review

Seems sane, but please don't RTBC your own patch. Could you get mradcliffe/jaredsmith to review?

  • catch committed 11fc96c on 8.0.x 
    Issue #2443669 by bzrudi71: PostgreSQL: Fix node\Tests\...
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Fixed

Cross-committed with Angie. I think Angie's review counts as a seconder on the patch...

Committed/pushed to 8.0.x, thanks!

bzrudi71’s picture

bzrudi71 commented

Actually it's not my patch, please see my comment in #1, so all credits to @jaredsmith please :-) Thanks for commit!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.