PostgreSQL: Fix system\Tests\Entity\EntityDefinitionUpdateTest

Looking into this a bit more regarding the second exception.

Oh, wait, the test for this exception SHOULD throw an exception. That's an odd way of doing that in this test. This seems to be added in #2232477: Fatal when adding new fields with NOT NULL constraints in a base table that contains existing entities.

Maybe testBundleFieldCreateDeleteWithExistingEntities should be changed to expect the exception? Is that possible with SimpleTest? It's possible in PHPUnit.

No, it's not possible. that's the common way to do it in Simplenews. It also wouldn't help to change it..

The problem seems to be that PostgreSQL throws a different exception that is not a DatabaseExceptionWrapper ?

I guess we just need to change this to catch DatabaseException instead, which is an interface that both the wrapper and IntegrityConstraintViolationException implement.

Oh, the thing that is uncommon is to then have another test in the catch(). I think the more common way is to just put a $this->pass() in there and have the code there below. But no need to change that here.

Oh, right. Thanks, @Berdir.

After this fix a get the following error:

Pass      Other      EntityDefinitionU  202 Drupal\system\Tests\Entity\EntityDe
    EntityDefinitionUpdateManager reports the expected change summary.
Exception Uncaught e Connection.php     152 Drupal\Core\Database\Driver\pgsql\C
    Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42704]: Undefined
    object: 7 ERROR:  index
    "drupal_sgaxxfwfxowfo7gtucqdrw8ltjwzbwmwj_bseumc_cs_idx" does not
    exist: DROP INDEX drupal_SgAXXFWfxoWfo7GTUcqDrw8lTjWzBwMWJ_bsEuMC_cs_idx;
    Array
    (
    )
     in
    Drupal\Core\Entity\Sql\SqlContentEntityStorageSchema->deleteSharedTableSchema()
    (line 1190 of
    /var/www/drupal80.com/drupal/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorageSchema.php).
    Drupal\Core\Database\Driver\pgsql\Connection->query('DROP INDEX
    drupal_SgAXXFWfxoWfo7GTUcqDrw8lTjWzBwMWJ_bsEuMC_cs_idx')
    Drupal\Core\Database\Driver\pgsql\Schema->dropIndex('entity_test_update',
    'entity_test_update_field__new_base_field__format')
    Drupal\Core\Entity\Sql\SqlContentEntityStorageSchema->deleteSharedTableSchema(Object,
    NULL)
    Drupal\Core\Entity\Sql\SqlContentEntityStorageSchema->performFieldSchemaOperation('delete',
    Object)
    Drupal\Core\Entity\Sql\SqlContentEntityStorageSchema->onFieldStorageDefinitionDelete(Object)
    Drupal\Core\Entity\Sql\SqlContentEntityStorage->onFieldStorageDefinitionDelete(Object)
    Drupal\Core\Entity\EntityManager->onFieldStorageDefinitionDelete(Object)
    Drupal\Core\Entity\EntityDefinitionUpdateManager->applyUpdates()
    Drupal\system\Tests\Entity\EntityDefinitionUpdateTest->testBaseFieldCreateUpdateDeleteWithoutData()
    Drupal\simpletest\TestBase->run(Array)
    simpletest_script_run_one_test('20',
    'Drupal\system\Tests\Entity\EntityDefinitionUpdateTest')

Sounds like the same problem as #2443659: PostgreSQL: Fix system\Tests\Entity\FieldSqlStorageTest ?

I have added the patch from #2443659: PostgreSQL: Fix system\Tests\Entity\FieldSqlStorageTest to the patch from comment #6. Also addded the following lines:

diff --git a/core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php b/core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php
index d4a96b3..0dd1dc6 100644
--- a/core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php
+++ b/core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php
@@ -549,6 +549,8 @@ public function fieldSetNoDefault($table, $field) {
   public function indexExists($table, $name) {
     // Details http://www.postgresql.org/docs/8.3/interactive/view-pg-indexes.html
     $index_name = $this->ensureIdentifiersLength($table, $name, 'idx');
+    // Remove leading and trailing quots.
+    $index_name = substr($index_name, 1, -1);
     return (bool) $this->connection->query("SELECT 1 FROM pg_indexes WHERE indexname = '$index_name'")->fetchField();
   }

@@ -562,6 +564,8 @@ public function indexExists($table, $name) {
    */
   public function constraintExists($table, $name) {
     $constraint_name = $this->ensureIdentifiersLength($table, $name);
+    // Remove leading and trailing quots.
+    $constraint_name = substr($constraint_name, 1, -1);
     return (bool) $this->connection->query("SELECT 1 FROM pg_constraint WHERE conname = '$constraint_name'")->fetchField();
   }

The EntityDefinitionUpdateTest passes with this patch.

Forgot the interdiff.txt.

Thank for the review bzrudi71.
Fixed all points from comment #10.

+++ b/core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php
@@ -549,6 +549,8 @@ public function fieldSetNoDefault($table, $field) {
+    // Remove leading and trailing quotes.
+    $index_name = substr($index_name, 1, -1);

This is more of a question.

What happens when the identifier is not hashed/quoted? Wouldn't this arbitrarily trim left and right characters of the identifier?

I am not sure.

Can we solve the removing of the leading and trailing quotes with: $index_name = str_replace('"', '', $index_name);?

Re-roll.

Updated issue summary.

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 7e24033 and pushed to 8.0.x. Thanks!

No new test fails are introduced by this fix for SQLite - this test does fail on SQLite but for another unrelated reason.

Stupid testbot!