Hello

I was having this problem in OA 2.31, so I installed a fresh Panopoly 1.18.
In admin/config/content/panelizer/user/user.page_manager/content I try to change the "user:field user picture" image style and after I save, it is not saved, it always stays panopoly_image_full. I have tried with image cropped and not cropped with not success.

Thanks for the distribution, I am learning a lot with it :)

CommentFileSizeAuthor
#25 panopoly_magic-broken-formatters-2443499-25.patch1.57 KBdsnopek
#22 panopoly_test-broken-formatters-2443499-22.patch3.32 KBdsnopek
#21 panopoly_test-broken-formatters-2443499-21.patch3.1 KBdsnopek
#19 Screenshot 2015-03-18 13.01.30.png32.29 KBhanoii
#18 panopoly_magic-broken-formatters-2443499-18.patch904 bytesdsnopek

Comments

candelas’s picture

candelas commented

I debugged more and the problem is that in Settings, Formatter options, when you select any formatter, and click Continue, any settings chosen in this second screen, in General Settings, are not saved and it keeps the default options.

candelas’s picture

candelas commented

Maybe this problem is related to Ctools new version. I found this issue #2152413: Ctools / Panels / Panelizer doesn't store field formatter settings of Textformatter Contrib that talks about a bug in Ctools #2152405: ctools_fields_get_field_formatter_settings_form() not fully compatible to field_ui that has being patched and is now in the release 7.x-1.6

candelas’s picture

candelas commented

I had applied patch in comment #4 in #2424017: Malformed (and useless) string context causes errors with new versions of CTools and I reverted and it had not change. I applied patch in comment #30 in #1259430: Convert entity_field to use #ajax for formatter options and I always got the options for image formatter when I changed from image to any other formatter. I was able to save a different image style, but that was not solving the problem, so I reverted it.

Any tips to solve this problem will be very welcome, thanks

candelas’s picture

candelas commented
Title: User profile: Unable to chage image style » User profile: Unable to chage image field style formatter options because they don't get saved
candelas’s picture

candelas commented
Category: Bug report » Feature request

Hello and sorry: its not caused by Panopoly, but by Panelizer :)

I've just installed Drupal 7.34, CTools 1.6, Panels 3.5 and Panelizer 3.1. Panelizer was giving me problems so I substituted with the one given by Open Atrium that has this patches

- http://drupal.org/files/issues/array-to-object-on-update-1623536-26.patch
- http://www.drupal.org/files/issues/panelizer-search_api-2416505-3.patch
- http://drupal.org/files/1982654-panelizer-dontaskmethatagain-2.patch

There I tested and for content types panelized the formatter settings for images are saved, but for the user no.
So I filled this #2444987: User images formatters settings not saved and change to feature request, so when a patch is created, I will ask to be included in Panopoly.

Again thanks, and have a good day :)

Until then, if another user has this problem, I used a display that is not panelized and only put the image where I can assign a formatter and its settings are saved. Then include as a panel pane in the content of the panelized full view.

candelas’s picture

candelas commented
Category: Feature request » Bug report

Hello

I tried Panelizer 7.x-3.2-beta1+17-dev with Drupal 7.34, CTools 1.6, Panels 3.5 and works.
So I tried with Panopoly 7.x-1.18, CTools 1.6, Panels 3.5 and Panelizer 7.x-3.2-beta1+17-dev and don't work.
Because of that I reclassify as a bug.

It looks like a new version 7.x-3.2 of Panelizer will come soon #2155813: Plan for Panelizer 7.x-3.2 release and a beta version is already there https://www.drupal.org/node/2418551

The menu has changed from Config to Structure, so links in Panelizer doesn't work, like

admin/config/content/panelizer/user/user.page_manager/content

should be

admin/structure/panelizer/user/user.page_manager/content

I hope this is useful to someone :)

aschmoe’s picture

aschmoe commented
Component: Users » Magic

Just did a little testing since I ran into the same issue, and found that virgin installs using latest panels + ctools have no issues with field formatter settings.

I then went down the list disabling likely culprits and found that panopoly_magic is the offending module.

Added the appropriate component label.

aschmoe’s picture

aschmoe commented

Looks like the issue stems from:

"Notice: Undefined index: ctools_field_list in ctools_entity_field_content_type_formatter_styles_submit() (line 234 of /modules/contrib/ctools/plugins/content_types/entity_context/entity_field.inc)."

So magic will need to update to deal with the new ctools submit structure.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Priority: Normal » Critical

This sounds like a regression, so I'm marking it as Critical.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue tags: +sprint
drupa11y’s picture

drupa11y commented

Just tried it with this config:
Panopoly 7.x-1.18+11-dev // 7.x-1.x-dev 2015-Mar-07,
CTools 1.6,
Panels 3.5 and
Panelizer 7.x-3.1
Panopoly Magic 7.x-1.18+2-dev

Result: don´t works.

When I try to edit the settings / formatter styles on the profile page I get the following errors:

1. Changing the "Image style":

An AJAX HTTP request terminated abnormally.
Debugging information follows.
Path: /panels/ajax/ipe/edit-pane/panelizer%3Auser%3A1%3Apage_manager/3/step2
StatusText: error
ResponseText: 
ReadyState: 0

2. Clicking "Finish":

An AJAX HTTP error occurred.
HTTP Result Code: 500
Debugging information follows.
Path: /panels/ajax/ipe/edit-pane/panelizer%3Auser%3A1%3Apage_manager/3/step2
StatusText: Service unavailable (with message)
ResponseText: Recoverable fatal error: Object of class stdClass could not be converted to string in devel_watchdog() (line 548 of /Applications/MAMP/htdocs/testlab_drupalDistros/panopoly-7.x/profiles/panopoly/modules/contrib/devel/devel.module).

Therefore I could only "exit" via "Cancel".

drupa11y’s picture

drupa11y commented

From the "reports/dbllog" I got these ones:

Warning: htmlspecialchars() expects parameter 1 to be string, object given in check_plain() (line 1583 of /Applications/MAMP/htdocs/testlab_drupalDistros/panopoly-7.x/includes/bootstrap.inc).

Location	http://panopoly7.test.local/panels/ajax/ipe/edit-pane/panelizer%3Auser%3A1%3Apage_manager/3/step2
Referrer	http://panopoly7.test.local/users/admin
Message	Context is missing for field: user:field_user_picture

Location	http://panopoly7.test.local/panels/ajax/ipe/edit-pane/panelizer%3Auser%3A1%3Apage_manager/3/step2
Referrer	http://panopoly7.test.local/users/admin
Message	Warning: Invalid argument supplied for foreach() in ctools_fields_get_field_formatter_info() (line 141 of /Applications/MAMP/htdocs/testlab_drupalDistros/panopoly-7.x/profiles/panopoly/modules/contrib/ctools/includes/fields.inc).

Location	http://panopoly7.test.local/panels/ajax/ipe/edit-pane/panelizer%3Auser%3A1%3Apage_manager/3/step2
Referrer	http://panopoly7.test.local/users/admin
Message	Notice: Undefined index: ctools_field_list in ctools_entity_field_content_type_formatter_styles_submit() (line 234 of /Applications/MAMP/htdocs/testlab_drupalDistros/panopoly-7.x/profiles/panopoly/modules/contrib/ctools/plugins/content_types/entity_context/entity_field.inc).

Location	http://panopoly7.test.local/panels/ajax/ipe/edit-pane/panelizer%3Auser%3A1%3Apage_manager/3/step2
Referrer	http://panopoly7.test.local/users/admin
Message	Warning: Creating default object from empty value in panopoly_magic_fape_submit() (line 1006 of /Applications/MAMP/htdocs/testlab_drupalDistros/panopoly-7.x/profiles/panopoly/modules/panopoly/panopoly_magic/panopoly_magic.module).

Location	http://panopoly7.test.local/panels/ajax/ipe/edit-pane/panelizer%3Auser%3A1%3Apage_manager/3
Referrer	http://panopoly7.test.local/users/admin
Message	Notice: Undefined property: stdClass::$type in panopoly_magic_form_ctools_entity_field_content_type_formatter_options_alter() (line 903 of /Applications/MAMP/htdocs/testlab_drupalDistros/panopoly-7.x/profiles/panopoly/modules/panopoly/panopoly_magic/panopoly_magic.module).

Location	http://panopoly7.test.local/panels/ajax/ipe/edit-pane/panelizer%3Auser%3A1%3Apage_manager/3
Referrer	http://panopoly7.test.local/users/admin
Message	Strict warning: Only variables should be passed by reference in panopoly_magic_form_ctools_entity_field_content_type_formatter_options_alter() (line 894 of /Applications/MAMP/htdocs/testlab_drupalDistros/panopoly-7.x/profiles/panopoly/modules/panopoly/panopoly_magic/panopoly_magic.module).
drupa11y’s picture

drupa11y commented

Disabling Devel removes the Ajax message and "Finish" is possible, but it does still not work.

drupa11y’s picture

drupa11y commented

Updated to Panopoly Magic 7.x-1.18+3-dev -> does not solve the problem

Updated to Panelizer 7.x-3.2-beta1+19-dev -> does not solve the problem

7 PENDING UPDATES
panelizer module

7111 - This update script was removed, nothing to see here.
7112 - Fix Panelizer settings.
7113 - Make {panelizer_entity}.view_mode NOT NULL.
7114 - Clear the menu cache to fix the display actions page arguments.
7115 - Ensure there's one display for each revision.
7116 - Ensure there's one display for each revision.
7117 - Clear the menu cache to pull in the new menu paths.

No Panelizer display records need fixing.
Fixed 0 Panelizer record(s) that were using the same display.
Note: the "Panelizer" tabs on content, user, term pages, etc have been renamed to "Customize display".
Note: the main Panelizer configuration page has moved to the "Structure" menu instead of the "Config" menu.

"admin/config/content/panelizer/user/user.page_manager/content" changed to
"admin/structure/panelizer/user/user.page_manager/content"

Log-Messages:

"admin/config/content/panelizer/user/user.page_manager/content" changed to
"admin/structure/panelizer/user/user.page_manager/content"

Location	http://panopoly7.test.local/panels/ajax/editor/edit-pane/panelizer%3Adefault%3Auser%3Auser.page_manager%3Adefault/3/step2
Referrer	http://panopoly7.test.local/admin/structure/panelizer/user/user.page_manager/content
Message	Notice: Undefined index: ctools_field_list in ctools_entity_field_content_type_formatter_styles_submit() (line 234 of /Applications/MAMP/htdocs/testlab_drupalDistros/panopoly-7.x/profiles/panopoly/modules/contrib/ctools/plugins/content_types/entity_context/entity_field.inc).
Severity	notice

Location	http://panopoly7.test.local/panels/ajax/editor/edit-pane/panelizer%3Adefault%3Auser%3Auser.page_manager%3Adefault/3/step2
Referrer	http://panopoly7.test.local/admin/structure/panelizer/user/user.page_manager/content
Message	Warning: Invalid argument supplied for foreach() in ctools_fields_get_field_formatter_info() (line 141 of /Applications/MAMP/htdocs/testlab_drupalDistros/panopoly-7.x/profiles/panopoly/modules/contrib/ctools/includes/fields.inc).
Severity	warning

Location	http://panopoly7.test.local/admin/structure/panelizer/user/user.page_manager/content
Referrer	http://panopoly7.test.local/admin/structure/panelizer/user/user.page_manager/content
Message	Panels: saved display with id 2
Severity	notice
drupa11y’s picture

drupa11y commented

Updated to Panels 7.x-3.5+0-dev & cTools 7.x-1.6+2-dev -> does not solve the problem
Logmessages as already mentioned above and

Notice: Undefined variable: id in ctools_argument_entity_id_context() (line 73 of /Applications/MAMP/htdocs/testlab_drupalDistros/panopoly-7.x/sites/default/modules/ctools/plugins/arguments/entity_id.inc).
astringer’s picture

astringer commented

Hi I'm getting what I believe is a similar error trying to format a number in a pane for a content type. The number is formatted in "manage displays" correctly. The number displays correctly (with a comma) in a non-panelized node view. But is incorrect in the panelized page (uses a space). It's like the setting doesn't get saved in Panelizer.

Log

Notice: Undefined index: ctools_field_list in ctools_entity_field_content_type_formatter_styles_submit() (line 234 of /srv/bindings/5d99bbe8f72c4604b28be8fc3d79423e/code/profiles/panopoly/modules/contrib/ctools/plugins/content_types/entity_context/entity_field.inc).

Notice: Undefined index: ctools_field_list in ctools_entity_field_content_type_formatter_styles_submit() (line 234 of /srv/bindings/5d99bbe8f72c4604b28be8fc3d79423e/code/profiles/panopoly/modules/contrib/ctools/plugins/content_types/entity_context/entity_field.inc).

Warning: Invalid argument supplied for foreach() in ctools_fields_get_field_formatter_info() (line 141 of /srv/bindings/5d99bbe8f72c4604b28be8fc3d79423e/code/profiles/panopoly/modules/contrib/ctools/includes/fields.inc).

When I try to edit the exact same (field format > comma) for a single node I get: 

An AJAX HTTP error occurred.
HTTP Result Code: 200
Debugging information follows.
Path: /panels/ajax/editor/edit-pane/panelizer%3Anode%3A29%3Apage_manager/241/step2
StatusText: OK
ResponseText: Fatal error: Call to undefined method stdClass::is_type() in /srv/bindings/5d99bbe8f72c4604b28be8fc3d79423e/code/profiles/panopoly/modules/contrib/ctools/includes/context.inc on line 147

Any ideas for a work around? I'm fairly new to drupal and very new to panels. Thanks.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

This is really affecting for a number of formatters, if not all of them. I have a registration field which is also failing to be saved. Disabling panopoly_magic seems to make it work for the time being, but really looking for a fix or better workaround. If there's any pointers I might try to take a look but probably not an easy one to fix for one that hasn't work on it.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs review
StatusFileSize
new panopoly_magic-broken-formatters-2443499-18.patch904 bytes

Thanks, @candelas, for all the research you did! This looks like a regression caused by this change to CTools, which you found: #2152405: ctools_fields_get_field_formatter_settings_form() not fully compatible to field_ui

Thanks, @mori, for all the testing and the detailed information you added here! That definitely helped me in figuring out how to fix this.

Anyway, here is a patch to panopoly_magic that should fix this! I may just commit it since this is a critical bug. But normally I wouldn't allow a change to panopoly_magic without simultaneously adding Behat tests, so I'm going to see how quickly I can put some together.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
StatusFileSize
new Screenshot 2015-03-18 13.01.30.png32.29 KB

It does work, however, I see [no preview] on every field, is that on purpose:

It's less critical though, but it was a nice feature.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

No, that's not on purpose! It's definitely a bug. But I think we should make a new issue for that, so we don't delay this one getting committed. Can you create the new issue and post your screenshot in it? Thanks!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new panopoly_test-broken-formatters-2443499-21.patch3.1 KB

Here's a patch to a Behat test for this functionality! It fails without the panopoly_magic patch, but passes with it. I'm going to run these both on Travis-CI quick, and if everything passes, I'll commit.

EDIT: Here's the Travis-CI build: https://travis-ci.org/panopoly/panopoly/builds/54893939

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new panopoly_test-broken-formatters-2443499-22.patch3.32 KB

Here's a new test patch! That one left the IPE open which broke subsequent tests. :-) I'll try on Travis-CI again once it's posted.

EDIT: Here's the Travis-CI build: https://travis-ci.org/panopoly/panopoly/builds/54904570

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

New bug created #2454947: Preview doesn't update when editing the value of a field via FAPE

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

@hanoii: Thanks! :-)

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new panopoly_magic-broken-formatters-2443499-25.patch1.57 KB

There was a PHP >= 5.4 error in panopoly_magic and the Travis-CI tests run on PHP 5.4. This new patch should fix it!

EDIT: Here is the Travis-CI build: https://travis-ci.org/panopoly/panopoly/builds/54916105

  • dsnopek committed b5384f3 on 7.x-1.x 
    Update Panopoly Magic and Test for Issue #2443499 by dsnopek: User...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

The tests passed! Committed. :-) Thanks again, everyone, who worked on this issue!

candelas’s picture

candelas commented

Thanks to you for all your generosity. I hope I finish with an installation with node.js and can test again to collaborate with Panopoly :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.