Formatter settings set by Picture are not deleted on uninstall. I noticed this when I encountered the bug described in #2403429: PDO Integrity constraint [error] violation: 1062 Duplicate entry 'image__default__file_field_picture' for key 'PRIMARY' It seems like good housekeeping to me to remove unneeded settings when the module is uninstalled. I'll post a patch shortly.

CommentFileSizeAuthor
#1 picture-delete-formatter-settings-on-uninstall-2443319-1.patch973 bytesnetbek

Comments

netbek’s picture

netbek commented
StatusFileSize
new picture-delete-formatter-settings-on-uninstall-2443319-1.patch973 bytes

A patch is attached to delete formatter settings on uninstall.

attiks’s picture

attiks commented
Assigned: Unassigned » jelle_s
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: picture-delete-formatter-settings-on-uninstall-2443319-1.patch, failed testing.

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs work » Fixed

Fixed in latest dev.

  • Jelle_S committed 99e04b6 on 7.x-2.x 
    Issue #2443319 by netbek, attiks: Field formatter settings not deleted...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.