Problem/Motivation

The initial step in the installer displays HTML as plain text:

Proposed resolution

Either remove the HTML entirely or display the HTML as HTML.

Remaining tasks

  1. Write a patch
  2. Review

User interface changes

The installer displays no HTML as text

API changes

None

CommentFileSizeAuthor
#11 drupal8-html_installer-2443005-11.patch1.18 KBgeertvd
#8 drupal8-html_installer-2443005-8.patch590 bytesgeertvd
#5 drupal8-html_installer-2443005-5.patch182.96 KBgeertvd
#4 drupal8-html_installer-2443005-4.patch555 bytesandrei.dincu
installer-html.png125.59 KBidebr

Comments

geertvd’s picture

geertvd commented

I can't reproduce this, the HTML in the initial step of the installer is being displayed as HTML

idebr’s picture

idebr commented

With javascript disabled you have more time between the steps to reproduce the bug. If I remember correctly the html text was limited to the initial text

andrei.dincu’s picture

andrei.dincu commented
Assigned: Unassigned » andrei.dincu
Status: Active » Needs work
andrei.dincu’s picture

andrei.dincu commented
Status: Needs work » Needs review
StatusFileSize
new drupal8-html_installer-2443005-4.patch555 bytes
geertvd’s picture

geertvd commented
StatusFileSize
new drupal8-html_installer-2443005-5.patch182.96 KB

I can reproduce this when JS is disabled.
Just removing the HTML is not a good idea though because it was added for a reason 

+++ b/core/includes/form.inc
@@ -713,8 +713,6 @@ function batch_set($batch_definition) {
     // Tweak init_message to avoid the bottom of the page flickering down after
-    // init phase.

I think this patch should fix it.

geertvd’s picture

geertvd commented

Woops that doesn't fix it, I still think we shouldn't be removing the html though.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Needs work

The latest patch reverts a bunch of recent core commits

geertvd’s picture

geertvd commented
StatusFileSize
new drupal8-html_installer-2443005-8.patch590 bytes

Forgot to rebase before making the patch, still doesn't fix the issue though.

geertvd’s picture

geertvd commented
Status: Needs work » Needs review
geertvd’s picture

geertvd commented
Status: Needs review » Needs work
geertvd’s picture

geertvd commented
Status: Needs work » Needs review
StatusFileSize
new drupal8-html_installer-2443005-11.patch1.18 KB

This should fix it.

geertvd’s picture

geertvd commented

Not sure how I can write a test for this, checked out InstallerTestBase but it looks like this takes care of all installation steps in setUp().

Actually this is a batch_api issue so we should probably write a test there. Still trying to figure out how to do that though, any ideas?

geertvd’s picture

geertvd commented
Issue tags: +needs manual test
stefan.r’s picture

stefan.r commented
Status: Needs review » Closed (duplicate)

Did we really have this for 6+ months?

There is an RTBC patch in #2548147: All batch labels are HTML escaped now so marking as duplicate

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: -needs manual test +Needs manual testing