Views dialog filter does not restripe

Seems good to me.

This looks good to me, i've been testing it manually, and actualy before we werent even handling this case at all.

+++ b/core/modules/views_ui/js/views-admin.js
@@ -380,9 +383,12 @@
           option.$div.removeClass('even odd');

This was not doing anything before, but with this patch it is necessary.

Given my limited CSS knowledge, I'm curios, whether the filtering itself could add a class for hidden/not hidden rows and then we use that in the CSS to change the style?

@dawehner Yes, I think we could use a :not(selector) here in theory, but we need to try it in practice, so setting to needs work. It would be a shame to introduce Javascript functionality just for this particular use case, and there an argument whether we need the zebra striping at all, as the Seven style guide remove this in favour of a hover color.

The problem here is that we can't use :nth-of-type(even) selector along with :not(selector)... they won't work together unfortunately.

So I don't see any other way around this, unless we indeed drop the zebra striping altogether.

Looks ok, can you just move the show() after classes have been messed with? Also since we're messing with things in this function can you reformat the variable declarations to be more in line with the rest:

 // Determine the user's search query. The search text has been converted to
      // lowercase.
      search = this.$searchBox.val().toLowerCase();
      words = search.split(' ');
      wordsLength = words.length;

      // Start the counter for restriping rows.
      zebraCounter = 0;

Transformed to :

 // Determine the user's search query. The search text has been converted to
      // lowercase.
      var search = this.$searchBox.val().toLowerCase();
      var words = search.split(' ');
      var wordsLength = words.length;

      // Start the counter for restriping rows.
      var zebraCounter = 0;

And remove those variable from the declaration in the first line.

Thanks :) that works.

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 4a7ab3e and pushed to 8.0.x. Thanks!