Recursion calculate dependencies in area plugin

Good catch!!! Do you think we should write a test here?

So what you would do is to write some code which calls out to

$this->viewHandler->calculateDependencies();

This itself might try to load the view itself, see $this->viewStorage->load($view_id)

In order for that to work, you have to mock the behaviour of the entity storage:

$view0 = $this->getMock('Drupal\views\ViewEntityInterface');
$view1 = $this->getMock('Drupal\views\ViewEntityInterface');

$this->entityStorage->expects($this->any())
  ->method('load')
  ->willReturnMap([
    ['id_0', $view0],
    ['id_1', $view1],
  ])

Feel free to ping me in IRC.

Awesome work

+++ b/core/modules/views/src/Plugin/views/area/View.php
@@ -158,7 +158,7 @@ public function calculateDependencies() {
-    if ($view_id) {
+    if ($view_id && $this->view->storage->id() != $view_id) {

It would be great to add a one-line documentation explaining why we need this check here.

Maybe try something like: // Ensure to not call the current view, as it would result into a infinite recursion.

Sorry for the endless nitpicking here ... i think its pointless to describe what the code is doing but rather we should describe why (which is doing the second part of the sentence).

+++ b/core/modules/views/src/Plugin/views/area/View.php
@@ -158,7 +158,9 @@ public function calculateDependencies() {
+    // Ensure to exists insert view id and not call the current view,
+    // as it would result into a infinite recursion.

I would vote for: "Don't call the current view, as it would result into an infinite recursion."

Thank you!

Great catch and nice patch. This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 0943b23 and pushed to 8.0.x. Thanks!