Problem/Motivation

Once upon a time RouteBuilderStatic was used to stop firing any kind of routing events inside update.php, for upgrading from d7 to d8.
Given that we replaced that with migrate we simply don't need this class anymore: #2001310: Disallow firing hooks during update

Proposed resolution

Remove it.

Remaining tasks

User interface changes

API changes

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, there is no bug.
Issue priority Normal, because it removes maintenance overhead
Disruption No disruption
CommentFileSizeAuthor
#1 drop_the_unused_class-2442173-1.patch1.19 KBmpdonadio

Comments

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented
Status: Active » Needs review
StatusFileSize
new drop_the_unused_class-2442173-1.patch1.19 KB

PhpStorm found no usages of RouteBuilderStatic in code, and no instances RouteBuilderStatic in any strings, comments, etc, outside of the file itself.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

So it did for me. Looks perfect

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Quickfix

.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Removing completely unused and untested code is permitted during beta. Committed 0aa2a08 and pushed to 8.0.x. Thanks!

  • alexpott committed 0aa2a08 on 8.0.x 
    Issue #2442173 by mpdonadio: Drop the unused class RouteBuilderStatic

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.