Problem/Motivation

Steps to reproduce:

  • Make your settings.php not writeable
  • Goto update.php
  • >WAT

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#3 update-remove-update_settings_file_requirements-2441867-1.patch1.69 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new update-remove-update_settings_file_requirements-2441867-1.patch1.69 KB

This removes it.

Given that we no longer support major updates, I don't think we still need write permissions on settings.php and if need to do something like that, that specific update can report an error if it doesn't work?

This currently prevents me from running update.php at all on our environment, as it deploys Drupal to a read-only file system.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Let's kill it.

I tried to write a test, but well, update.php tried to rewrite the settings.php anyway.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new update-remove-update_settings_file_requirements-2441867-1.patch1.69 KB

Uploading the file again.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 268c4f2 and pushed to 8.0.x. Thanks!

  • alexpott committed 268c4f2 on 8.0.x 
    Issue #2441867 by Berdir: Don't require settings.php to be writeable in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.