Follow-up to #2433009: Add Mink, with Goutte driver, to core

Problem/Motivation

The parent issue #2232861: Create BrowserTestBase for web-testing on top of Mink added Mink and Goutte to Drupal in preparation for #2232861: Create BrowserTestBase for web-testing on top of Mink. However, since current releases of Goutte depend on Guzzle 3, the dev-master branch was used.

From #2232861: Create BrowserTestBase for web-testing on top of Mink:

@fabpot just rolled 2.0.3 so can we get a follow up to remove dev-master for Goutte?

Proposed Resolution

Use ^2.0.3 for version for Goutte. This is equivalent to >=2.0.3 <3.0.0. See https://getcomposer.org/doc/01-basic-usage.md#next-significant-release-t....

Remaining tasks

Create the patch.
Review and commit the patch.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#1 update_release_goutte-2440937-1.patch5 KBhussainweb

Comments

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review
Issue tags: -blocker +Quickfix
StatusFileSize
new update_release_goutte-2440937-1.patch5 KB

There is no change to code, so the patch only contains changes to composer.json, composer.lock and vendor/composer/installed.json.

Also, I don't think this is a blocker, but leaving it as Major based on the parent issues.

hussainweb’s picture

hussainweb
Primary language English
commented
Issue summary: View changes

Updating the IS to explain the use of caret operator in the version.

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 4936e3d and pushed to 8.0.x. Thanks!

  • alexpott committed 4936e3d on 8.0.x 
    Issue #2440937 by hussainweb: Update release for Goutte driver

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.