On admin/modules page all "people permissions" links the same:
admin/people/permissions
admin/people/permissions
admin/people/permissions
instead of:
admin/people/permissions#module-block
admin/people/permissions#module-comment
admin/people/permissions#module-node

CommentFileSizeAuthor
#8 module_filter-link_options-2437439-8.patch830 bytesgreenskin
#7 module-filter-bug-ie-03312015.gif43.4 KBkatannshaw
#7 module-filter-bug-chrome-03312015.gif42.42 KBkatannshaw
#7 module-filter-bug-firefox-03312015.gif47.88 KBkatannshaw
#3 module_filter-add_link_fragment-2437439-3.patch487 bytesmikhailkrainiuk

Comments

Teastwood’s picture

Teastwood commented

Hello,

I've got the same problem here.

It seems to be located in module_filter.theme.inc > function theme_module_filter_operations(&$vars) : if $links[$key]['#options']['fragment'] exists and is not empty, the array added into $operations[] should contain 'fragment' => $links[$key]['#options']['fragment'] (and any other options available for links?). If there's not dropbutton, the link is rendered with its fragment ; if there's a dropbutton, only the title and href of the link are sent into $operations[], and we lose the fragment.

Is there a reason for this?

Thanks!

katannshaw’s picture

katannshaw commented

Same issue here with Drupal 7.34 and Module Filter 7.x-2.0.

mikhailkrainiuk’s picture

mikhailkrainiuk commented
Version: 7.x-2.0 » 7.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new module_filter-add_link_fragment-2437439-3.patch487 bytes

Hello,

I create a patch. It works for me fine.

Please review it.

Ivan Simonov’s picture

Ivan Simonov commented

Thanks for the patch.
I test it with Version: 7.x-2.0 and Version: 7.x-2.0+9-dev
Links became correct, but behaviour still strange.

Go to link "/admin/people/permissions#module-module_filter" and come to the top of the permissions page.
After this I click into browser address field and press Enter, and I come to the correct part of the page.
Mozilla Firefox for Ubuntu, Version: 36.0
If "Module Filter" is disabled at all, permission links behaviour is correct.

katannshaw’s picture

katannshaw commented

I've tried the patch from #3 and can report the same behavior as Ivan Simonov reported.

mikhailkrainiuk’s picture

mikhailkrainiuk commented

I had checked it.
This is a bug of Firefox - https://bugzilla.mozilla.org/show_bug.cgi?id=645075
And bug on Bugzilla is opened now.

There are many solutions on the Internet, but with JavaScript only.
I think, this module doesn't need a JS script for solving this problem with Firefox. I hope Firefox will be repared.

katannshaw’s picture

katannshaw commented
StatusFileSize
new module-filter-bug-firefox-03312015.gif47.88 KB
new module-filter-bug-chrome-03312015.gif42.42 KB
new module-filter-bug-ie-03312015.gif43.4 KB

@kraynuk.m: That's strange, because I don't see this only in Firefox. I see the same bug in Firefox, Chrome and IE, and I've attached 3 screenshots to show this for my install of 7.x-2.0.

greenskin’s picture

greenskin commented
StatusFileSize
new module_filter-link_options-2437439-8.patch830 bytes

Here's a patch that utilizes the original link options from core, which includes the fragments for permissions.

katannshaw’s picture

katannshaw commented

@greenSkin: I just tested your patch on my local site and it worked great. Thanks for the patch!

greenskin’s picture

greenskin commented
Status: Needs review » Reviewed & tested by the community

  • greenSkin committed 5b9ca31 on 7.x-2.x 
    Issue #2437439 by mikhail.krainiuk, greenSkin, jayhawkfan75: Module...
greenskin’s picture

greenskin commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.