ERFormatterBase standardizes code and behavior for loading referenced entities to display (access check, translation handling...)
TaxonomyFormatterBase has its own duplicate-but-different implementation. We should re-base it on EntityReferenceFormatterBase

+ it still has weird/old side behaviors like modifying the îtems in the entity being viewed, which is an antipattern. Thus, filing as a bug.

Comments

yched’s picture

yched CreditAttribution: yched commented

We'll need to decide if we do that or wait for #2433513: [PP-1] TaxonomyFormatterBase should extend EntityReferenceFormatterBase :-)

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

I'd suggest we should wait for #1847596: Remove Taxonomy term reference field in favor of Entity reference.

yched’s picture

yched CreditAttribution: yched commented
Status: Active » Postponed

At any rate, this is postponed on #2405469: FileFormatterBase should extend EntityReferenceFormatterBase

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Postponed » Active
Related issues: +#2405469: FileFormatterBase should extend EntityReferenceFormatterBase, +#1847596: Remove Taxonomy term reference field in favor of Entity reference

#2405469: FileFormatterBase should extend EntityReferenceFormatterBase is in, so unpostponing… but I think this is now actually still postponed on #1847596: Remove Taxonomy term reference field in favor of Entity reference?

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Related issues: +#2099137: Entity/field access and node grants not taken into account with core cache contexts

And this would greatly simplify #2099137: Entity/field access and node grants not taken into account with core cache contexts.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

This is actually postponed on #1847596: Remove Taxonomy term reference field in favor of Entity reference, which is postponed on two independent chains of issues:

  1. #2446613: Fix MigrateVocabularyFieldTest
  2. #2446511: Add a "preconfigured field options" concept in Field UI which is blocked on #2373491: Categorize field type plugins
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Title: TaxonomyFormatterBase should extend EntityReferenceFormatterBase » [PP-4] TaxonomyFormatterBase should extend EntityReferenceFormatterBase
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Title: [PP-4] TaxonomyFormatterBase should extend EntityReferenceFormatterBase » [PP-3] TaxonomyFormatterBase should extend EntityReferenceFormatterBase

#2373491: Categorize field type plugins is in.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Title: [PP-3] TaxonomyFormatterBase should extend EntityReferenceFormatterBase » [PP-2] TaxonomyFormatterBase should extend EntityReferenceFormatterBase

#2446613: Fix MigrateVocabularyFieldTest was closed as a duplicate. So now down again.

#6 referred to #2099137: Entity/field access and node grants not taken into account with core cache contexts, not #1847596: Remove Taxonomy term reference field in favor of Entity reference. Fixed that.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Title: [PP-2] TaxonomyFormatterBase should extend EntityReferenceFormatterBase » [PP-1] TaxonomyFormatterBase should extend EntityReferenceFormatterBase
Status: Active » Postponed

#2446511: Add a "preconfigured field options" concept in Field UI landed.

Now only blocked on #1847596: Remove Taxonomy term reference field in favor of Entity reference.

amateescu’s picture

amateescu CreditAttribution: amateescu commented

Actually, it seems like this should be closed as a duplicate when that lands, no? :)

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

I was actually going to ask you exactly that. I didn't realize the other patch included the formatter changes. I guess the formatter changes must happen in that issue, right?

amateescu’s picture

amateescu CreditAttribution: amateescu commented

There are no changes needed AFAIS, that issue simply removes TaxonomyFormatterBase in favor of EntityReferenceFormatterBase.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Postponed » Closed (duplicate)

Okay, marking this is a duplicate :)