Problem/Motivation

The WWW-Authenticate response header is not passed to the browser when BasicAuth sends the challenge. As a result, browsers do not display the authentication prompt.

Proposed resolution

Remaining tasks

Update tests.

User interface changes

API changes

CommentFileSizeAuthor
#3 2432657-add-headers-in-exception-subscriber-3-patch-only.patch1.08 KBberdir
#3 2432657-add-headers-in-exception-subscriber-3.patch2.17 KBberdir
#1 2432657-add-headers-in-exception-subscriber.diff1.09 KBznerol

Comments

znerol’s picture

znerol commented
Status: Active » Needs review
StatusFileSize
new 2432657-add-headers-in-exception-subscriber.diff1.09 KB
dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Needs tests

We certainly needs tests here I would say. Looks like a reasonable fix though.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Issue tags: -Needs tests
StatusFileSize
new 2432657-add-headers-in-exception-subscriber-3.patch2.17 KB
new 2432657-add-headers-in-exception-subscriber-3-patch-only.patch1.08 KB

That should be enough for tests?

Status: Needs review » Needs work

The last submitted patch, 3: 2432657-add-headers-in-exception-subscriber-3-patch-only.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

Grml.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

+1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 48f6e29 and pushed to 8.0.x. Thanks!

  • alexpott committed 48f6e29 on 8.0.x 
    Issue #2432657 by Berdir, znerol: BasicAuth challenge never sent to...
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Component: user system » basic_auth.module

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.