Problem/Motivation

The FileViewsData still has references to taxonomy vocabularies, even this won't work anymore, because vocabularies are config entities
and so no longer can be joined.

Proposed resolution

Remove every mention of vocabularies in that file.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#9 cleanup_fileviewsdata-2432257-9.patch7.15 KBpjbaert
#3 cleanup_fileviews-2432257-3.patch7.7 KBalvar0hurtad0

Comments

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
Assigned: Unassigned » alvar0hurtad0

Let me try

:)

dawehner’s picture

dawehner
Primary language German
commented

Awesome!

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
Assigned: alvar0hurtad0 » Unassigned
Status: Active » Needs review
StatusFileSize
new cleanup_fileviews-2432257-3.patch7.7 KB

OK,

this is the patch I've removed all refferences to taxonomies and terms on

core/modules/file/src/FileViewsData.php

suggestions?

Status: Needs review » Needs work

The last submitted patch, 3: cleanup_fileviews-2432257-3.patch, failed testing.

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
Status: Needs work » Needs review

Errr,

this is the error on the qa system:
File /tmp/some-temp-file.jpg could not be copied to temporary://some-temp-file.jpg. migrate MigrateTestBase.php 141 Drupal\migrate\Tests\MigrateTestBase->display()

I'll send to retest.

alvar0hurtad0 queued 3: cleanup_fileviews-2432257-3.patch for re-testing.

geertvd’s picture

geertvd commented
Status: Needs review » Needs work

I think you should just be removing references to taxonomy_vocabulary and not to taxonomy_term_data.

dawehner’s picture

dawehner
Primary language German
commented
Title: Cleanup FileViews » Cleanup FileViewsData
pjbaert’s picture

pjbaert
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new cleanup_fileviewsdata-2432257-9.patch7.15 KB

I agree with @geertvd
In this patch, I only remove references to taxonomy_vocabulary.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented

Ups, I came to fix the patch and the job is allready done.

:)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Category: Task » Bug report
Status: Reviewed & tested by the community » Fixed

This is a bug. This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 729966c and pushed to 8.0.x. Thanks!

  • alexpott committed 729966c on 8.0.x 
    Issue #2432257 by alvar0hurtad0, pjbaert: Cleanup FileViewsData

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.