Problem/Motivation

In order to make RouteProviderTest be testable via a KernelTestBaseNG approach, the test method has to be public

testRouteByName though is not

Proposed resolution

Make testRouteByname a public method

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#8 change-function-type-to-public-2431053-8.patch690 bytessiva_epari
#4 change-function-type-to-public-2431053-3.patch674 byteszealfire
#2 change-function-type-to-public-2431053-2.patch673 byteszealfire

Comments

dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes
Issue tags: +Novice, +Quickfix

Let's add some tags.

zealfire’s picture

zealfire commented
Status: Active » Needs review
StatusFileSize
new change-function-type-to-public-2431053-2.patch673 bytes

Changing to public type.Please review.
Thanks.

Status: Needs review » Needs work

The last submitted patch, 2: change-function-type-to-public-2431053-2.patch, failed testing.

zealfire’s picture

zealfire commented
StatusFileSize
new change-function-type-to-public-2431053-3.patch674 bytes

uploading a new patch.

zealfire’s picture

zealfire commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: change-function-type-to-public-2431053-3.patch, failed testing.

siva_epari’s picture

siva_epari commented
Assigned: Unassigned » siva_epari
siva_epari’s picture

siva_epari commented
Status: Needs work » Needs review
StatusFileSize
new change-function-type-to-public-2431053-8.patch690 bytes

Re-rolled patch to 8.0.x

siva_epari’s picture

siva_epari commented
Assigned: siva_epari » Unassigned
zealfire’s picture

zealfire commented

@epari thanks for re-rolling, I had earlier forgotten to pull latest version hence test were failing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

The last patch looks perfect

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Can't really see a reason not to do this.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 212aa13 on 8.0.x 
    Issue #2431053 by zealfire, epari.siva, dawehner: RouteProviderTest::...
zealfire’s picture

zealfire commented

hurray,finally a patch contributed by me and committed by webchick :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Aw, happy to help :D thanks for the patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.