Now that all our tests are depending on the demo content from panopoly_demo, there really aren't any tests that make sure the content got pulled in via Migrate correctly!

So, we should add a couple tests to demo.feature, which make sure that at least one node and one menu item got created correctly.

CommentFileSizeAuthor
#7 panopoly_behat_demo_content-2430975-7.patch1.15 KBshawn dearmond
#4 panopoly_behat_demo_content-2430975-4.patch1.11 KBshawn dearmond
#3 panopoly_behat_demo_content-2430975-3.patch1.01 KBshawn dearmond

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue tags: +sprint
shawn dearmond’s picture

shawn dearmond commented
Assigned: Unassigned » shawn dearmond
shawn dearmond’s picture

shawn dearmond commented
Status: Active » Needs review
StatusFileSize
new panopoly_behat_demo_content-2430975-3.patch1.01 KB

Added tests for demo content and menu items.

shawn dearmond’s picture

shawn dearmond commented
StatusFileSize
new panopoly_behat_demo_content-2430975-4.patch1.11 KB

Updated patch to specify region.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Reviewed & tested by the community

Applies, add coverage for the default coverage

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Needs work

Thanks! Everything looks good except one bit of review:

+++ b/tests/features/demo.feature
@@ -8,3 +8,20 @@ Feature: Demo content
+    When I visit "/node/2"

We shouldn't depend on "/node/2" being a particular page. Using the alias would be better, but avoiding a specific URL and clicking a link would be best!

shawn dearmond’s picture

shawn dearmond commented
Status: Needs work » Needs review
StatusFileSize
new panopoly_behat_demo_content-2430975-7.patch1.15 KB

Changed the starting place to /demo and followed a link like @dsnopek recommended.

shawn dearmond’s picture

shawn dearmond commented
Assigned: shawn dearmond » Unassigned

unassigning

  • dsnopek committed 375864a on 7.x-1.x 
    Update Panopoly Test for Issue #2430975 by Shawn DeArmond: Add Behat...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Thanks! Committed. :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.