Problem/Motivation

The patch in #2422363: Rewrite the menu CSS components inline with our CSS standards changed the selector from the Bartik primary navigation toggle.

Before:
body:not(:target) .region-primary-menu .menu-toggle-target-show:target ~ .menu li {

After:
body:not(:target) .region-primary-menu .menu-toggle-target-show:target ~ .menu-item {

This breaks the primary navigation toggle.

Additional information from http://www.w3.org/TR/selectors/

8.3.2. General sibling combinator

The general sibling combinator is made of the "tilde" (U+007E, ~) character that separates two sequences of simple selectors. The elements represented by the two sequences share the same parent in the document tree and the element represented by the first sequence precedes (not necessarily immediately) the element represented by the second one.

Screencap before:

Proposed resolution

Fix the selector so the primary navigation in Bartik can be toggled again.

Remaining tasks

  1. Write a patch
  2. Review

User interface changes

The primary navigation in Bartik can be toggled again.

API changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because the primary navigation has become unreachable for visitors on a small viewport
Issue priority Major because the primary navigation has become unreachable for visitors on a small viewport and there is no workaround
Unfrozen changes Unfrozen because it only changes CSS.
CommentFileSizeAuthor
#1 2430735-1.patch593 bytesidebr
#1 2430735-1.gif33.37 KBidebr
bartik-menu-toggle.gif17.84 KBidebr

Comments

idebr’s picture

idebr commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2430735-1.gif33.37 KB
new 2430735-1.patch593 bytes

Attached patch fixes the CSS selector so the primary navigation can be toggled again.

Screencap after:

lewisnyman’s picture

lewisnyman
he/him
commented
Status: Needs review » Reviewed & tested by the community

This looks good to me, thanks for the patch and the gifs.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 0990ace and pushed to 8.0.x. Thanks!

  • alexpott committed 0990ace on 8.0.x 
    Issue #2430735 by idebr: Primary navigation toggle broken in Bartik
juankvillegas’s picture

juankvillegas commented

idebr, totally offtopic but... what software do you use to create those nice gifs?

idebr’s picture

idebr commented

@juankvillegas

I used LiceCap: https://github.com/lepht/licecap

Installers available from http://www.cockos.com/licecap/

juankvillegas’s picture

juankvillegas commented

Thank you... very easy to use.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.