Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.There is an options in Panopoly Admin module, that allows to hide the promote and sticky options from the node edit form.
But this form alteration is made in the global hook_form_alter() hook without any check against the current form.
So this also alters any other form that has an 'options' key and may have unexpected results.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | panopoly_admin-alteration-of-node-options-conflict-2429327-3.patch | 5.13 KB | b-prod |
Comments
Comment #1
b-prod commentedThe patch below fixes the issue and factorize the alterations common to the node edit form, for better readability.
Comment #2
dsnopekThanks! I think this should be fine, I'll just need to do some manual testing to make sure we weren't expecting this to clean up the Fieldable Panels Pane edit form as well.
However, this contains unrelated whitespace fixes. Can you re-roll the patch without those? We don't merge patches with unrelated changes, even if they are good ones because they can break other patches in the queue. See this issue for more details:
#2447605: [META] Perform coding style fixes
Comment #3
b-prod commentedThis patch should not contain any changes related to the syntax (my IDE automatically fixes such things, that's why these changes appear in the patch).
The patch has been rerolled on the latest DEV version.
Comment #4
dsnopekPatch looks great! Manual testing looked good. I've committed this - let's see what Travis-CI thinks:
https://travis-ci.org/panopoly/panopoly/builds/55168502
Thanks, @B-Prod for your work on this!