API page: https://api.drupal.org/api/drupal/includes%21form.inc/function/form_proc...
The page says "#empty_option: (optional) The label to show for the first default option. By default, the label is automatically set to "- Please select -" for a required field..." but in fact the label shown is just '- Select -'.
I discovered this as I wanted to change the default label to a much more friendly 'Please select' in my own form.
Beta evaluation: Unfrozen - API docs changes only.
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | interdiff.txt | 813 bytes | joshi.rohit100 |
| #20 | D7-Empty_label_documentation-2428399-29.patch | 894 bytes | joshi.rohit100 |
| #19 | D7-Empty_label_documentation-2428399-19.patch | 762 bytes | pushpinderchauhan |
| #6 | D8-processSelect-Empty-Label-Documentation-2428399-6.patch | 1013 bytes | drupalgideon |
| #2 | D7-Empty_label_documentation-2428399.patch | 762 bytes | sagar ramgade |
Comments
Comment #1
jhodgdonThanks for the report! This should be an easy Novice project to fix the documentation.
Comment #2
sagar ramgade commentedPatch attached :-)
Comment #3
zealfire commented@Sagar Ramgade,you should always set the status to "Needs review" whenever you submit a patch because then only it would be sent for testing and people can know that it need to be reviewed :)
Comment #4
jhodgdon@zealfire means to set it to "Needs Review". :)
Anyway, the patch looks good, thanks!
Comment #5
David_Rothstein commentedLooks good, but we should fix this in Drupal 8 also; the same issue exists there - Drupal\Core\Render\Element\Select::processSelect()
Comment #6
drupalgideonJust so happened to be playing with D8 this weekend so I thought I'd create this patch as I reported the issue!
Comment #7
joshi.rohit100I was about to upload the same patch :)
Comment #8
dom. commentedHi !
Patch #6 tested (manually applied) and reviewed (manually read through).
I thought comments should not exceed 80 characters but it aligns with the rest at 82, so no issue here.
RTBC+1
Comment #9
dom. commentedRemove backport need to D7: created dedicated clone issue here for that : #2462835: Default empty option label text different in documentation.
Comment #10
David_Rothstein commentedActually, we should leave the backport in this issue in order to be able to track the work better (see https://www.drupal.org/node/767608). I'll close the other as a duplicate.
Comment #11
David_Rothstein commentedBy the way, I agree with RTBC for the Drupal 8 patch :)
Comment #12
dom. commented@David_Rothstein : I did not know, now I know !
Thanks
Comment #13
jhodgdonThanks, looks good for 8, and I verified the defaults are as in the docs. Adding beta eval to summary.
Comment #16
jhodgdonShould be back to RTBC unless the patch doesn't apply and the test bot complains. I assume that was a random test failure?
Comment #17
alexpottCommitted 443ef75 and pushed to 8.0.x. Thanks!
Comment #19
pushpinderchauhan commentedD7 patch.
Comment #20
joshi.rohit100I think #2 is same as #19. I have just made this same as #6 :)
Comment #21
jhodgdonThanks, looks good! I just double-checked and it is true as written in D7.
Comment #23
damienmckennaI'm going to work on this as part of Drupal Ladder training for NHDevDays :)
Comment #24
damienmckennaThe test that fails has no bearing on this patch - the patch only affects a comment, the test that fails is checking something on the tableselect output. Putting this patch back RTBC.
Comment #25
damienmckennaComment #26
David_Rothstein commentedCommitted to 7.x - thanks!