The SQLite Schema class is missing use Drupal\Component\Utility\Unicode.

Solution

  • Add "use Drupal\Component\Utility\Unicode" to the SQLite Schema class

Testing
php ./scripts/run-tests.sh --dburl sqlite://localhost/sqlite/db.sqlite --file core/modules/system/src/Tests/Database/SchemaTest.php
There should be no fails and no exceptions.

Commit credits
Please give @sun commit credits for this issue. All the code from the patch from the first comment is originally written by @sun.

CommentFileSizeAuthor
#3 2428377-3.patch589 bytesamateescu
#1 2428377-1.patch586 bytesdaffie

Comments

daffie’s picture

daffie commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2428377-1.patch586 bytes
daffie’s picture

daffie commented
Priority: Normal » Major
Issue summary: View changes

If I run the test locally I get the following result:


Drupal test run
---------------

Tests to be run:
  - Drupal\system\Tests\Database\SchemaTest

Test run started:
  Wednesday, February 18, 2015 - 11:08

Test summary
------------

Drupal\system\Tests\Database\SchemaTest                      649 passes

Test run duration: 4 min 57 sec

Because this issue stops its parent issue, I have changed its priority to major.

amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 2428377-3.patch589 bytes

Manually checked the file and PHPStorm also complains about this missing use statement. While I was there, I noticed that we can also remove one use statement that is not needed anymore.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Quickfix

.

daffie’s picture

daffie commented

Good catch amateescu!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 7b3189d and pushed to 8.0.x. Thanks!

  • alexpott committed 7b3189d on 8.0.x 
    Issue #2428377 by sun, daffie, amateescu: SQLite Schema class is missing...

Status: Fixed » Needs work

The last submitted patch, 3: 2428377-3.patch, failed testing.

amateescu’s picture

amateescu commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.