Problem/Motivation

FeedViewBuilder::buildComponents() uses #path instead of #uri when building the feed image render array

Proposed resolution

Switch #path to #uri. Add a test to avoid future regressions

Remaining tasks

Review
Commit

User interface changes

The feed image now actually displays, instead of showing just the alt text.

API changes

None

CommentFileSizeAuthor
#1 2427409.patch1.29 KBParisLiakos
#1 2427409-FAIL.patch721 bytesParisLiakos

Comments

ParisLiakos’s picture

ParisLiakos commented
Status: Active » Needs review
StatusFileSize
new 2427409-FAIL.patch721 bytes
new 2427409.patch1.29 KB

The last submitted patch, 1: 2427409-FAIL.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Looks good and has test coverage.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed e26375e and pushed to 8.0.x. Thanks!

  • alexpott committed e26375e on 8.0.x 
    Issue #2427409 by ParisLiakos: Feed image doesnt display

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.