Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
simpletest.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
15 Feb 2015 at 10:40 UTC
Updated:
15 Mar 2015 at 10:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehner.
Comment #2
dawehnerThis time with the right patch.
Comment #3
jhodgdonHm. The new docs look a bit confusing. If the kernel is not updated by this method, then I think we should just take out the mention of the kernel from the docs? As it is I was confused about the kernel mention.
I'm also not sure that the $request = \Drupal::request(); is a complete no-op. It doesn't seem to break anything in the automated tests, but the method is capable of actually resetting an array pointer if you trace it down the stack. And in any case, if you're going to remove that line of code this needs to move to the simpletest component as it's not just docs.
Comment #4
daffie commentedLooks good to me.
The part with the kernel instance is not necessary.
Comment #5
alexpottTest code is not subject to beta restrictions. Committed e40099f and pushed to 8.0.x. Thanks!
I improved the comment. The unused $request has been bothering me for ages.