Secondary level of tabs do not render correctly in Bartik.

Drupal includes some routes but they are in the admin area.

  1. Set admin theme to Bartik.
  2. Go to page with two levels of tabs. For example:
    • Config import/export: /admin/config/development/configuration/full/import [Image]
    • Theme settings: /admin/appearance/settings [Image]
    • Custom module: [Image]

This is less an issue for core admin routes as it is for contrib, as I doubt many switch to Bartik for admin theme.

Bartik example

CommentFileSizeAuthor
#5 after.PNG8.32 KBdpi
#5 before.PNG8.75 KBdpi
#1 2426553-1.patch411 bytesidebr
#1 2426553-1.png428.21 KBidebr
bartik_3.PNG20.65 KBdpi
bartik_2.PNG8.26 KBdpi
bartik_1.PNG15.53 KBdpi

Comments

idebr’s picture

idebr commented
Title: Secondary tabs do not flow correctly » Secondary tabs do not flow correctly in Bartik
Priority: Major » Normal
Issue summary: View changes
Status: Active » Needs review
Issue tags: +frontend, +CSS
StatusFileSize
new 2426553-1.png428.21 KB
new 2426553-1.patch411 bytes

Nice find, @dpi!

Considering the secondary tabs are not displayed by the default configuration, I think the 'Normal' priority is more appropriate.

I added a clearfix to the secondary tabs in the same way it is added to the primary tabs in Bartik:

dpi’s picture

dpi
Location Perth, Australia
commented

Looks good to me, fixed all three of my examples!

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs review

What happens when you have so many secondary tabs it has to break to the next line?

dpi’s picture

dpi
Location Perth, Australia
commented
StatusFileSize
new before.PNG8.75 KB
new after.PNG8.32 KB

Multi-line secondary tabs arn't exactly pretty, but they look the same whether the patch is applied or not. Unless we want to make the scope of this issue bigger? Or am I missing something?

Multi line: before / after.

idebr’s picture

idebr commented
Status: Needs review » Reviewed & tested by the community

@dpi I'm assuming @alexpott wanted to make sure multiple lines would still be visible in the UI or only the first line would be visible. Thanks for adding the screenshots :)

Back to RTBC per #3

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2426553-1.patch, failed testing.

isntall queued 1: 2426553-1.patch for re-testing.

idebr’s picture

idebr commented
Status: Needs work » Reviewed & tested by the community

I didn't have an opportunity to see what happened in #7, but since it came back green I'm assuming it was a testbot hickup. Back to RTBC per #3

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Boy, #5 has quite lovely screenshots. ;) Agreed though that they look the same before/after, with the exception that "after" doesn't push the table over to the far right-hand side.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 5a34273 on 
    Issue #2426553 by dpi, idebr: Secondary tabs do not flow correctly in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.