Views no longer supports {{ something }} as twig placeholder for a path, only {{something}}

--deleted-- wrong comment

Failing patch using the view/path that I found the problem with.

Coffee hasn't kicked in...

Here is a version using preg_replace that passes locally w/ the adjusted path from #10

Dug into why #6 doesn't fail. It has to do with the logic in Url::toUriString().

'node/{{ nid }}' in views.view.test_dropbutton.yml is being parsed as an unrouted URL before token replacement, and since there are no query parameters, nothing is getting escaped, and Twig is happy. See #2426399: FieldPluginBase::renderAsLink() loses language prefix for tokenized paths for a related issue to this.

'admin/content/files/usage/{{ fid }}' in views.view.files.yml is being parsed as a routed URL before token replacement; so the route parameters are being escaped by UrlHelper::buildQuery(), including the spaces (and the escaped spaces are what are causing Twig grief).

Yup. Wasn't thinking there. Fixed locally, but I am going to see if I can add some proper unit test coverage for this.

Yikes. Not sure if I went too far (ie, did I make out of scope changes) to get the test coverage to actually work...

1. +++ b/core/modules/views/src/Plugin/views/PluginBase.php
   @@ -576,4 +582,18 @@ public static function queryLanguageSubstitutions() {
   +  /**
   +   * Returns the render API renderer.
   +   *
   +   * @return \Drupal\Core\Render\RendererInterface
   +   */
   +  protected function getRenderer() {
   +    if (!isset($this->renderer)) {
   +      $this->renderer = \Drupal::service('renderer');
   +    }
   +
   +    return $this->renderer;
   +  }
   +
   

   I'm curios whether we should instead introduce a RendererTrait ? Would that be helpful for other places as well?

2. +++ b/core/modules/views/tests/src/Unit/Plugin/field/FieldPluginBaseTest.php
   @@ -422,6 +434,65 @@ public function providerTestRenderAsLinkWithUrlAndOptions() {
   +
   +    $data[] = ['test-path/{{foo}}', $tokens, $link_html];
   +    $data[] = ['test-path/{{ foo}}', $tokens, $link_html];
   +    $data[] = ['test-path/{{  foo}}', $tokens, $link_html];
   +    $data[] = ['test-path/{{foo }}', $tokens, $link_html];
   +    $data[] = ['test-path/{{foo  }}', $tokens, $link_html];
   +    $data[] = ['test-path/{{ foo }}', $tokens, $link_html];
   +    $data[] = ['test-path/{{  foo }}', $tokens, $link_html];
   +    $data[] = ['test-path/{{ foo  }}', $tokens, $link_html];
   +    $data[] = ['test-path/{{  foo  }}', $tokens, $link_html];
   

   Nice coverage!

Re #17-1, I had to do this for test mocking purposes, and there are one or two other places in core that do this (and a bunch that wrap drupal_render_root). drupal_render() and drupal_render_root() are marked as deprecated, but I am not finding an issue to actually remove them. How about we leave this here, and I open a followup? That way we have an in-scope issue to swap out the duplicate methods / direct calls with the trait. That would put likely put a big dent into the drupal_render() and drupal_render_root() calls in classes where the service isn't injected.

+++ b/core/modules/views/src/Plugin/views/PluginBase.php
@@ -104,6 +104,12 @@
+  /**
+   * Stores the render API renderer.
+   *
+   * @var \Drupal\Core\Render\Renderer
+   */
+  protected $renderer;

Should probably be RendererInterface instead. Also in FieldPluginBase.

Re #17-1, I had to do this for test mocking purposes, and there are one or two other places in core that do this (and a bunch that wrap drupal_render_root). drupal_render() and drupal_render_root() are marked as deprecated, but I am not finding an issue to actually remove them. How about we leave this here, and I open a followup? That way we have an in-scope issue to swap out the duplicate methods / direct calls with the trait. That would put likely put a big dent into the drupal_render() and drupal_render_root() calls in classes where the service isn't injected.

Fair, let's go with the follow up.

And yes, we do have an interface for that, so let's use it.

Updated type hints. This should be good to go.

Committed d6458cd and pushed to 8.0.x. Thanks!

diff --git a/core/modules/views/tests/src/Unit/Plugin/field/FieldPluginBaseTest.php b/core/modules/views/tests/src/Unit/Plugin/field/FieldPluginBaseTest.php
index 326c43d..4e3bd73 100644
--- a/core/modules/views/tests/src/Unit/Plugin/field/FieldPluginBaseTest.php
+++ b/core/modules/views/tests/src/Unit/Plugin/field/FieldPluginBaseTest.php
@@ -154,9 +154,7 @@ protected function setUp() {
     $this->unroutedUrlAssembler = $this->getMock('Drupal\Core\Utility\UnroutedUrlAssemblerInterface');
     $this->linkGenerator = $this->getMock('Drupal\Core\Utility\LinkGeneratorInterface');
 
-    $this->renderer = $this->getMockBuilder('Drupal\Core\Render\RendererInterface')
-      ->disableOriginalConstructor()
-      ->getMock();
+    $this->renderer = $this->getMock('Drupal\Core\Render\RendererInterface');
 
     $container_builder = new ContainerBuilder();
     $container_builder->set('url_generator', $this->urlGenerator);

Fixed on commit.