Follow-up to #1847280: Simpletest web tests misnamed as "Unit"

Problem/Motivation

The class UserAccountLinksTests don't fulfill tests coding standards https://www.drupal.org/node/325974. The definition is now closed, so we can rename according that.
The file is /core/modules/user/src/Tests/UserAccountLinksTests.php
The file was find in the issue #1847280: Simpletest web tests misnamed as "Unit".

Proposed resolution

  • Rename the class and file to fullfil standards.

Remaining tasks

  • Rename the class and file to fullfil standards.

User interface changes

No.

API changes

No.

CommentFileSizeAuthor
#5 rename-useraccountlinkstest-2426323-5.patch784 bytesbetoscopio
#2 rename-useraccountlinkstest-2426323-2.patch780 bytesbetoscopio

Comments

betoscopio’s picture

betoscopio
Primary language Spanish
commented
Parent issue: #1847280: Simpletest web tests misnamed as "Unit" » #1446366: [meta] Multiple web test classes mislabeled as unit tests. simpletest ([Web|Unit|DrupalUnit]TestBase)

Updating parent issue.

betoscopio’s picture

betoscopio
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new rename-useraccountlinkstest-2426323-2.patch780 bytes

Uploading a patch that changes the name of the file and the class acording to coding standars.

Status: Needs review » Needs work

The last submitted patch, 2: rename-useraccountlinkstest-2426323-2.patch, failed testing.

betoscopio’s picture

betoscopio
Primary language Spanish
commented
Issue tags: +LatinAmerica2015

Adding tag of sprint.

betoscopio’s picture

betoscopio
Primary language Spanish
commented
StatusFileSize
new rename-useraccountlinkstest-2426323-5.patch784 bytes

Reuploading the patch, fixing the name of the class.

betoscopio’s picture

betoscopio
Primary language Spanish
commented
Status: Needs work » Needs review
daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

This is about tests and that is allowed for beta-changes.

Good work @betoscopio.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Rename UserAccountLinksTests subclass from WebTestBase acording to code standards » Rename UserAccountLinksTests to UserAccountLinksTest
Status: Reviewed & tested by the community » Fixed

Committed f54e5a7 and pushed to 8.0.x. Thanks!

  • alexpott committed f54e5a7 on 8.0.x 
    Issue #2426323 by betoscopio: Rename UserAccountLinksTests to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.