Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Right now the query factory and the query itself require both the config factory and the config storage.
A year ago (#2188595: Create a ConfigManager to be able to remove config.inc) a listAll() was added to config factory, so Query has no reason to use the storage directly anymore.
(ConfigEntityStorage also uses only the config factory nowadays as well, so this would be consistent with it).
This is an internal cleanup that doesn't any external code.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2425497-3-stop-injecting-storage-to-config-query.patch | 4.58 KB | bojanz |
| #1 | 2425497-1-stop-injecting-storage-to-config-query.patch | 3.88 KB | bojanz |
Comments
Comment #1
bojanz commentedComment #3
bojanz commentedLess stupid this time.
Comment #4
tim.plunkettI remember grumbling about needing both of these, but there was no listAll() on config.factory back then.
+1 for cleaning this up now.
Comment #5
dawehnerGreat simplification.
Comment #8
tim.plunkettRandom fail
Comment #9
alexpottThe reason I've been hesitating from committing this obvious clean up is because I'm still thinking about how we can optimise query config entities.
Comment #10
webchickSending over Alex's way given #9.
Comment #11
alexpott#2430219: Implement a key value store to optimise config entity lookups won't need the storage so let's proceed here because less dependencies and complexity here is a good thing. Committed 78fd4d0 and pushed to 8.0.x. Thanks!