Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
core/misc/print.css is failing lintcss test
Proposed resolution
remove unused #menu & #main (not used anymore)
odd & even classes corrected
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#15 | csslint-2425013-15.patch | 417 bytes | aliyakhan |
#11 | csslint-print.diff | 461 bytes | mortendk |
#5 | new_print2.png | 139.33 KB | kandra |
#5 | new_print1.png | 340.83 KB | kandra |
#5 | original_print2.png | 139.24 KB | kandra |
Comments
Comment #1
rteijeiro CreditAttribution: rteijeiro commentedIt looks great!
Comment #2
LewisNyman CreditAttribution: LewisNyman commentedGiven that we are changing table styling, a screenshot with a table in would be nice ;-)
Also, I can see that we are removing the decision to hide the menu, this makes sense, as core shouldn't really be that opinionated about what themes do with their menus when printed.
I wonder how much print CSS we really need to be global across all themes, I know that this issue is about only csslint fixes but it would be nice to clean it up even more in this issue or a follow up.
Comment #3
mortendk CreditAttribution: mortendk commentedyeah print.css should live in the theme, as they normally allready do
I have a sneaky suspision that misc/print.css was added at some point where print stylesheets was the hot stuff, so it got dropped into misc/ to never be heard from again ;)
Comment #4
LewisNyman CreditAttribution: LewisNyman commentedI have asked someone to work on the screenshots for tables at Drupalcon
Comment #5
kandra CreditAttribution: kandra commentedLooks good with tables. I'm attaching the original screenshots and how it looks after applying the patch.
And after applying the patch
Comment #6
mortendk CreditAttribution: mortendk commented*highfive to kandra for the screenshots*
Comment #7
LewisNyman CreditAttribution: LewisNyman commentedI had a quick chat with Morten in IRC and we agreed that we will create a follow up that will attempt to remove this CSS file completely.
Comment #8
LewisNyman CreditAttribution: LewisNyman commentedComment #10
mortendk CreditAttribution: mortendk commentedcone on testbot
Comment #11
mortendk CreditAttribution: mortendk commentedreuoloads the same patch as it seems to be gone missing ??
Comment #12
mortendk CreditAttribution: mortendk commentedsets back to RTBC based on #7 after testbot got drunk
Comment #13
alexpott.odd and .even are exceptionally generic - let's leave this alone.
Comment #14
mortendk CreditAttribution: mortendk commentedwe should use:
as we will remove all .odd / .even classes
Comment #15
aliyakhan CreditAttribution: aliyakhan commentedI've replaced it with nth-child
tr.odd {
background-color: #ddd;
}
tr.even {
background-color: #fff;
}
with
tr:nth-child(odd) {
background-color: #ddd;
}
tr:nth-child(even){
background-color: #fff;
}
Also, as per #14 there are no pseudo classes as :odd & :even for now.
Comment #16
aliyakhan CreditAttribution: aliyakhan commentedComment #17
mortendk CreditAttribution: mortendk commented@aliyakhan cool this should bring a bit more happiness in the frontend
Comment #18
webchickCommitted and pushed to 8.0.x. Thanks!