The 2.5 version of menu block was recently released:

https://www.drupal.org/node/2420375

It includes the patch currently being applied to menu_block in the panopoly_widgets makefile.

CommentFileSizeAuthor
#9 update_menu_block-2424709-9.patch640 bytesjoegraduate
#1 update_menu_block-2424709-1.patch509 bytesjoegraduate

Comments

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Status: Active » Needs review
StatusFileSize
new update_menu_block-2424709-1.patch509 bytes

Here is a patch.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Thanks! Committed. :-)

  • dsnopek committed f8128b2 on 7.x-1.x 
    Update Panopoly Widgets for Issue #2424709 by joegraduate: Update '...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Fixed » Active

Hrm. Not sure why, but the commit with this change is failing the automated tests on Travis-CI:

https://travis-ci.org/panopoly/panopoly/builds/50504351

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs work

This does actually appear to be related to a change in menu_block - here's the salient error from Travis:

https://gist.github.com/dsnopek/79d92cd6833d6cbef842

So, I'm going to revert this for now! It either means there is a new bug in menu_block that is breaking things, or that we need to adjust the Panopoly code for changes to menu_block.

  • dsnopek committed d907b21 on 7.x-1.x 
    Revert "Update Panopoly Widgets for Issue #2424709 by joegraduate:...
joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented

Looks like it's a known issue and fix has been committed to the dev version of menu_block:
https://www.drupal.org/node/2421645

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Related issues: +#2421645: Recoverable fatal error: Argument 3 passed to menu_tree_prune_tree() must be of the type array, boolean given
joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
StatusFileSize
new update_menu_block-2424709-9.patch640 bytes

Updated patch.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Status: Needs work » Needs review
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue tags: +sprint

Adding to the sprint

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Here's a Behat build of the last patch: https://travis-ci.org/panopoly/panopoly/builds/62733561

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Reviewed & tested by the community

Travis hasn't kicked off yet, but my local tests are passing.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Assigned: Unassigned » joegraduate
Status: Reviewed & tested by the community » Needs review

Gonna try to do a little manual testing of this...

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Status: Needs review » Reviewed & tested by the community

Can't seem to reproduce the problem in manual testing. The parent/upstream issue suggests that the problem only affects PHP 5.3 but I could not duplicate the problem in a PHP 5.3 environment either. Dave Reid does seem pretty confident that the parent issue is resolved though (this patch includes his fix) and I think this is ready to go.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Fixed

Sounds good! Committed :-)

  • dsnopek committed 35bb72c on 7.x-1.x 
    Update Panopoly Widgets for Issue #2424709 by joegraduate: Update '...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.