Follow-up to #2424365: Labels for layouts are hidden through CSS

Normally, when a user is choosing a layout for a page, they don't care about the name of the layout (i.e. "Radix" "Selma" etc). However, in terms of documentation and troubleshooting, it would be nice to reference the name for each layout. I noticed the labels are there but are hidden from CSS. Here's what it looks like when I remove the "display: none" from the CSS.

Is there any reason, besides aesthetics, that we are hiding the labels?

Comments

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Code in question

panopoly_theme/css/panopoly-layouts.css

#panels-layout-category-Radix-wrapper .panels-layouts-category,
#panels-layout-category-Radix-wrapper .layout-link div {
  display: none;
}

This is existing in pre-Radix switch, as well, didn't find code.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

It's purely for aesthetics. I've done a client project where they wanted to see the labels, so we undid that in CSS in the custom theme.

I don't personally have a real strong feeling about hiding or showing them, other than than not wanting to cause expected regressions for existing sites that are already using (and liking) the hidden titles.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Closed (won't fix)

I think I'm going to mark this as "won't fix". It's pretty easy to show the labels in a custom theme via CSS.

I do think there is an accessibility issue here, in that the layout name should be in the link for screenreaders (probably best in the image alt text), so I'm going to open a seperate issue for that: #2427993: Layout names not available to screenreaders in "Change layout" dialog