Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.most important changes:
- removed max-height for the summaries, I had to add a little span.clear to views-ui-edit-tab.tpl.php to make the containing div wrap around the three columns
- another look for the active display tab
- a border-right for the smaller divs within ajax-pad
- explicit border: 0 for the throbber gif
- some styling of the preview section
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | viewsuiupdate2.patch | 4.52 KB | yoroy |
| #3 | viewsuiupdate.patch | 4.37 KB | yoroy |
| views-ui-b4.patch | 5.58 KB | yoroy | |
Comments
Comment #1
merlinofchaos CreditAttribution: merlinofchaos commentedcommitted!
Comment #2
merlinofchaos CreditAttribution: merlinofchaos commentedI had to roll back this patch. Try looking at filters such as Node: Posted date -- they're totally messed up with this patch. I couldn't figure out what was wrong, exactly, either.
Comment #3
yoroy CreditAttribution: yoroy commentedHere's another go. I find it difficult to tweak the more complex forms in the ajax-pad for e.g. arguments. Basically left them untouched so those should at least be not messed up by this.
http://drupal.org/node/256090 proposes a smaller, less 'noisy' help icon for advanced help that works quite nice here.
I'm open to suggestions for other areas of improvement, I'm not so good with the more complex features so feel free to point them out in the interface…
Comment #4
merlinofchaos CreditAttribution: merlinofchaos commentedMinor comments:
I don't like losing the background texture behind the add display/analyze buttons. They end up floating in nowhere.
The background for the title of each the section doesn't extend all the way to the left but it does extend all the way to the right, so that feels a little wrong.
The add/rearrange buttons don't center within that background area, either, so they seem a little out of place.
The marker for overridden fields/filters/etc got lost, tho it's fine on individual items.
It doesn't feel right to me to have no left border on the tabs.
Comment #5
yoroy CreditAttribution: yoroy commentedBackground color for display/analyze buttons is back.
I've removed the background for each section title because if I remove the padding of the containing box, all other links move to the side too, and these each only have a unique class name, not a common generic one that I can use to add padding there. Hadn't noticed it though, good catch.
Hopefully the add/rearrange icons behave now, I think I found what caused them to move left a bit (the left border does). Could only check this in FF, never reproduced it in Safari. If it works though, then http://drupal.org/node/254340 is fixed as well.
The marker for overridden fields etc should be back now, some CSS was, shall we say 'overriding' it further down the cascade…
Overall, I toned down the borders a bit and added them back to the left side of the tab area.
Comment #6
yoroy CreditAttribution: yoroy commentedComment #7
merlinofchaos CreditAttribution: merlinofchaos commentedI restored the title backgrounds and did a little tweaking, and committed this. However, I have one request:
It'd be awesome to have an arrow background to put in the active tab, on the right. That'd make it very clear what the active tab is doing, since it would have a visual flow into the tab area.
Comment #8
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.