core/authorize.php is an unrouted URL, so `Url::fromUri('base:core/authorize.php')` is the proper way to build a Url object for it. The current comment in system_authorized_get_url() is totally wrong, and this proper usage should be documented.

CommentFileSizeAuthor
#2 2423953-01.patch734 bytesmpdonadio
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio commented
Status: Active » Needs review

Quick comment change.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio commented
FileSize
2423953-01.patch734 bytes

Actually add the patch this time.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio commented
Parent issue: » #2417827: Evaluate and document each use of base: in core
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs review » Fixed

Agreed.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed e6967af on 8.0.x 
    Issue #2423953 by mpdonadio: Properly comment use of Url::fromUri('base:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.