Problem/Motivation

The following two issues that were committed recently added small CSS regressions from each of them.

#2402639: Rename the footer regions in Bartik
#2398447: Remove the "typography" CSS file in Bartik

View the issues to see a comment of which one added what.

Here is what the footer looks like at head now.
 

 

 

Proposed resolution

Write a patch, putting back the CSS using coding standards approved CSS into the relevant component file for the footer in css/components folder

Remaining tasks

Write a patch
Review the patch
Add screenshots

User interface changes

none

API changes

none

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because it is regressions caused by commits of other issues to Core
Unfrozen changes Unfrozen because it is theme related and only changes CSS
Prioritized changes The main goal of this issue is to fix regressions in Bartik in Core
Disruption Non disruptive
CommentFileSizeAuthor
#7 d8-padding.jpeg12.08 KBmherchel
#4 Screen Shot 2015-02-09 at 13.52.54.png29.33 KBemma.maria
#4 Screen Shot 2015-02-09 at 13.52.47.png36.12 KBemma.maria
#4 Screen Shot 2015-02-09 at 13.52.32.png51.35 KBemma.maria
#3 footer-regressions-2422975-3.patch930 bytesemma.maria
#3 beta-6.png76.99 KBemma.maria
#3 my-patch.png56.39 KBemma.maria
after typography.css remove.png32.2 KBemma.maria
before typography.css remove.png34.54 KBemma.maria
after footer rename.png32.77 KBemma.maria
before footer rename.png35.03 KBemma.maria

Comments

emma.maria’s picture

emma.maria
she/her
commented
Related issues: +#2398447: Remove the "typography" CSS file in Bartik, +#2402639: Rename the footer regions in Bartik
idebr’s picture

idebr commented

I also noticed this regression while working on #2398451: Clean up "layout" CSS in Bartik and have included a fix in there:

+++ b/core/themes/bartik/css/components/footer.css
@@ -1,7 +1,45 @@
-#footer-wrapper {
+#site-footer__wrapper {
   font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
emma.maria’s picture

emma.maria
she/her
commented
Assigned: emma.maria » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new my-patch.png56.39 KB
new beta-6.png76.99 KB
new footer-regressions-2422975-3.patch930 bytes

OK I will be putting all of the fixes in one patch here as I want to keep track of the committed bugs in one place. It turns out we changed markup in #2402639: Rename the footer regions in Bartik and that wasn't part of the issue and then we didn't clean/amend the redundant selectors :(

Patch attached

and here are the screenshots...

I only provided "desktop" screenshots as the styles cover all widths.

Drupal 8.0.0-beta-6

My work

emma.maria’s picture

emma.maria
she/her
commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2015-02-09 at 13.52.32.png51.35 KB
new Screen Shot 2015-02-09 at 13.52.47.png36.12 KB
new Screen Shot 2015-02-09 at 13.52.54.png29.33 KB
emma.maria’s picture

emma.maria
she/her
commented
Title: The footer has CSS regressions. » Bartik footer has CSS regressions.
idebr’s picture

idebr commented
Status: Needs review » Reviewed & tested by the community

There are the exact same fixes I made in #2398451: Clean up "layout" CSS in Bartik, so they I guess they will merge. Thanks emma for bugtracking these :)

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new d8-padding.jpeg12.08 KB

Looking good!

D8 Padding

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed e62841e on 8.0.x 
    Issue #2422975 by emma.maria, mherchel, idebr: Bartik footer has CSS...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.