Problem/Motivation

CSS lint errors in search.admin.css

Line	Column	Message
9	1	2 IDs in the selector, really?
12	1	2 IDs in the selector, really?

Proposed resolution

user decent selectors & no dobbelt id's (really)

Remaining tasks

User interface changes

None.

API changes

None.

Beta evaluation

This is an unfrozen change (CSS), besides which it is only a CSS cleanup that has been verified not to make any visual changes. Should be OK to commit.

CommentFileSizeAuthor
#5 search_admin_css_css-2422409-5.patch518 bytesmortendk
#2 searc-admin-css-lint-patched.png104.74 KBmortendk
#2 searc-admin-css-lint-original.png105.19 KBmortendk
searc-admin-css-lint.diff516 bytesmortendk

Comments

mortendk’s picture

mortendk commented
Issue summary: View changes
mortendk’s picture

mortendk commented
Issue summary: View changes
StatusFileSize
new searc-admin-css-lint-original.png105.19 KB
new searc-admin-css-lint-patched.png104.74 KB

screenshots - patched

Original

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Needs work 
  1. +++ b/core/modules/search/css/search.admin.css
@@ -6,9 +6,9 @@
-#search-admin-settings #edit-add-page {
+.search-admin-settings .container-inline {

    Seems a bit generic, are all container-inline's to act like this? 

  2. +++ b/core/modules/search/css/search.admin.css
@@ -6,9 +6,9 @@
-#search-admin-settings #edit-add-page label {
+.search-admin-settings label[for=edit-search-type] {

    for's value should be quoted as that seems to be our standard.

mortendk’s picture

mortendk commented

@joel yes on the search admin settings page they should - simply changed the selected from the ID to the class.

mortendk’s picture

mortendk commented
Status: Needs work » Needs review
StatusFileSize
new search_admin_css_css-2422409-5.patch518 bytes
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

@mortendk ok, that is the only .inline-container on that page... so I guess that will do. Thanks for the attribute selector quote fix.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Issue summary: View changes

Thanks both of you! Added beta eval.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 1671091 on 8.0.x 
    Issue #2422409 by mortendk, joelpittet: search.admin.css css lint...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.