Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
CSS lint errors in search.admin.css
Line Column Message
9 1 2 IDs in the selector, really?
12 1 2 IDs in the selector, really?
Proposed resolution
user decent selectors & no dobbelt id's (really)
Remaining tasks
User interface changes
None.
API changes
None.
Beta evaluation
This is an unfrozen change (CSS), besides which it is only a CSS cleanup that has been verified not to make any visual changes. Should be OK to commit.
Comment | File | Size | Author |
---|---|---|---|
#5 | search_admin_css_css-2422409-5.patch | 518 bytes | mortendk |
#2 | searc-admin-css-lint-patched.png | 104.74 KB | mortendk |
#2 | searc-admin-css-lint-original.png | 105.19 KB | mortendk |
searc-admin-css-lint.diff | 516 bytes | mortendk | |
Comments
Comment #1
mortendk CreditAttribution: mortendk commentedComment #2
mortendk CreditAttribution: mortendk commentedscreenshots - patched
Original
Comment #3
joelpittetSeems a bit generic, are all container-inline's to act like this?
for's value should be quoted as that seems to be our standard.
Comment #4
mortendk CreditAttribution: mortendk commented@joel yes on the search admin settings page they should - simply changed the selected from the ID to the class.
Comment #5
mortendk CreditAttribution: mortendk commentedComment #6
joelpittet@mortendk ok, that is the only
.inline-container
on that page... so I guess that will do. Thanks for the attribute selector quote fix.Comment #7
jhodgdonThanks both of you! Added beta eval.
Comment #8
webchickCommitted and pushed to 8.0.x. Thanks!