Problem/Motivation

The comment CSS in Seven isn't been used, see: #658704: Make the node meta distinct from body

Proposed resolution

Remove the file

Remaining tasks

User interface changes

None

API changes

None

CommentFileSizeAuthor
#10 seven-remove-comment-css-2422365-11.patch809 byteslewisnyman
css-lint-comments.diff319 bytesmortendk

Comments

Status: Needs review » Needs work

The last submitted patch, css-lint-comments.diff, failed testing.

Status: Needs work » Needs review

mortendk queued css-lint-comments.diff for re-testing.

mortendk’s picture

mortendk commented
Version: 8.1.x-dev » 8.0.x-dev

Status: Needs review » Needs work

The last submitted patch, css-lint-comments.diff, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review
Issue tags: +Needs screenshots

I wonder where submitted comments show up in the seven theme, regardless it could use screenshots if you can find them.

joelpittet queued css-lint-comments.diff for re-testing.

lewisnyman’s picture

lewisnyman
he/him
commented
Title: css lint comments » Remove redundant comments
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: -Needs screenshots

I traced this code back to this issue: #658704: Make the node meta distinct from body

I guess at some point in Drupal 7 there was a node listing that displayed comments? I have not seen this at all in Drupal 8. Let's remove this CSS file completely.

lewisnyman’s picture

lewisnyman
he/him
commented
Title: Remove redundant comments » Remove redundant comments styling
mortendk’s picture

mortendk commented

we'll then rtbc ?

lewisnyman’s picture

lewisnyman
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new seven-remove-comment-css-2422365-11.patch809 bytes

@mortendk Ok fine here is the patch ;-)

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

Sounds like a plan. I can't see where an admin page with a comment div.submitted would be of use anyway.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: seven-remove-comment-css-2422365-11.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Reviewed & tested by the community

Random, testbot disdain for CSS.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

CSS is not frozen in beta. Committed 8f61c0d and pushed to 8.0.x. Thanks!

  • alexpott committed 8f61c0d on 8.0.x 
    Issue #2422365 by mortendk, LewisNyman: Remove redundant comments...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.