Problem/Motivation

#page-title is removed from seven page.hmtl.twig - the css is still there in page-title.css

Proposed resolution

  1. remove the #page-title thats unused

Remaining tasks

User interface changes

API changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mortendk’s picture

idebr’s picture

Component: CSS » Seven theme
joelpittet’s picture

Status: Needs review » Needs work

Noticed that ID does still exist:


html/core/themes/seven/templates/install-page.html.twig:
   14    <header role="banner">
   15      {% if site_name %}
   16:       <h1 class="page-title">{{ site_name }}</h1>
   17      {% endif %}
   18    </header>


html/core/themes/seven/templates/maintenance-page.html.twig:
   14    <header role="banner">
   15      {% if site_name %}
   16:       <h1 class="page-title">{{ site_name }}</h1>
   17      {% endif %}
   18    </header>


html/core/themes/seven/templates/page.html.twig:
   62        {{ title_prefix }}
   63        {% if title %}
   64:         <h1 class="page-title">{{ title }}</h1>
   65        {% endif %}
   66        {{ title_suffix }}
mortendk’s picture

i cant see any ids ?

joelpittet’s picture

Status: Needs work » Reviewed & tested by the community

LOL NM, those are all classes, only IDs are in bartik.

joelpittet’s picture

Title: remove page-title id from sevens css » Remove #page-title id from sevens CSS
Issue summary: View changes
LewisNyman’s picture

Looks good! RTBC++

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

CSS is not frozen. Committed abea960 and pushed to 8.0.x. Thanks!

  • alexpott committed abea960 on 8.0.x
    Issue #2422351 by mortendk: Remove #page-title id from sevens CSS
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.