Problem/Motivation

#page-title is removed from seven page.hmtl.twig - the css is still there in page-title.css

Proposed resolution

  1. remove the #page-title thats unused

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
page-title-patch.png80.66 KBmortendk
page-title-unpatched.png150.17 KBmortendk
seven-page-title-id.diff404 bytesmortendk

Comments

mortendk’s picture

mortendk commented
Parent issue: » #1190252: [573] Use csslint as a weapon to beat the crappy CSS out of Drupal core

patched:

unpatched

idebr’s picture

idebr commented
Component: CSS » Seven theme
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Needs work

Noticed that ID does still exist:


html/core/themes/seven/templates/install-page.html.twig:
   14    <header role="banner">
   15      {% if site_name %}
   16:       <h1 class="page-title">{{ site_name }}</h1>
   17      {% endif %}
   18    </header>


html/core/themes/seven/templates/maintenance-page.html.twig:
   14    <header role="banner">
   15      {% if site_name %}
   16:       <h1 class="page-title">{{ site_name }}</h1>
   17      {% endif %}
   18    </header>


html/core/themes/seven/templates/page.html.twig:
   62        {{ title_prefix }}
   63        {% if title %}
   64:         <h1 class="page-title">{{ title }}</h1>
   65        {% endif %}
   66        {{ title_suffix }}
mortendk’s picture

mortendk commented

i cant see any ids ?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Reviewed & tested by the community

LOL NM, those are all classes, only IDs are in bartik.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: remove page-title id from sevens css » Remove #page-title id from sevens CSS
Issue summary: View changes
lewisnyman’s picture

lewisnyman
he/him
commented

Looks good! RTBC++

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

CSS is not frozen. Committed abea960 and pushed to 8.0.x. Thanks!

  • alexpott committed abea960 on 8.0.x 
    Issue #2422351 by mortendk: Remove #page-title id from sevens CSS

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.