Problem/Motivation

appearance-page.css have loads of csslint errors & unessesry css thats already declared other places

Proposed resolution

* change selectors to be more precise
* remove css that's duplicated

Remaining tasks

visual confirmation on no regression on apparence page : /admin/appearance

User interface changes

API changes

CommentFileSizeAuthor
#1 with-patch.png380.01 KBmortendk
#1 without-patch.png387.39 KBmortendk
apperance-seven-csslint.diff506 bytesmortendk

Comments

mortendk’s picture

mortendk commented
Issue summary: View changes
Issue tags: +csslint
StatusFileSize
new without-patch.png387.39 KB
new with-patch.png380.01 KB

With patch:

without patch:

mortendk’s picture

mortendk commented
Issue summary: View changes
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

Screenshot shows it doesn't change anything (with the h3 bold/normal headers) and I double checked to make sure.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

CSS is not yet frozen. Committed 98a0fda and pushed to 8.0.x. Thanks!

  • alexpott committed 98a0fda on 8.0.x 
    Issue #2422341 by mortendk: seven appearance-page.css css cleanup
lewisnyman’s picture

lewisnyman
he/him
commented

Thanks, please remember to keep CSS changes for the Seven theme under the Seven theme component, and just tag it with CSS.

I also made a follow up: #2423577: Remove Seven's appearance-page.css

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Component: CSS » Seven theme

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.