No templates, sorry. These are trivial bugfixes.

CommentFileSizeAuthor
#3 tests.patch1.11 KBchx
tests.patch1.71 KBchx

Comments

chx’s picture

chx commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, tests.patch, failed testing.

chx’s picture

chx commented
Title: WebTestBase hardwires session and breaks settings » WebTestBase breaks settings
Status: Needs work » Needs review
StatusFileSize
new tests.patch1.11 KB
daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

The variable $directory is defined by: 

$directory = DRUPAL_ROOT . '/' . $this->siteDirectory;

The in the function Settings::initialize() is a require made: 

require DRUPAL_ROOT . '/' . $directory . '/settings.php';

The DRUPAL_ROOT variable is added twice. The patch uses the variable $this->siteDirectory instead of $directory. So that fixes the problem.

Good work @chx!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

No need to test the tests I guess. This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 29c7efa and pushed to 8.0.x. Thanks!

  • alexpott committed 29c7efa on 8.0.x 
    Issue #2422243 by chx: WebTestBase breaks settings

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.