CommentItem should override the generateSampleValue method and provide sample values

Just confirming... with both this patch and the one on the devel_generate thread, devel_generate works again :)

This needs a test like done in \Drupal\datetime\Tests\DateTimeItemTest. I checked for CommentItemTest.php but there is none.

cd core/module
grep -r generateSampleValue *
grep -r " extends FieldItemBase" *

Looking into this, the issue comes a little upstream, comments are not created the same way that the rest of the fields.

This will need some more work in terms of how to be able to pass the entities to generateValues without breaking the interface and also pool the author of the comment from the existing users.

Here's a patch in the good direction, I think

Content seems to be generated fine (using patch #3 from devel_generate issue), but when I visit a node with comments, I see this fatal error:
Fatal error: Call to a member function label() on a non-object in /var/www/drupal8/core/modules/comment/src/Entity/Comment.php on line 402

This code is enough to make devel work (tested)
Probably needs to extend with other fields from CommentItem::propertyDefinitions()

1. +++ b/core/modules/comment/src/Plugin/Field/FieldType/CommentItem.php
   @@ -193,4 +196,29 @@ public function storageSettingsForm(array &$form, FormStateInterface $form_state
   +  public static function generateSampleValue(FieldDefinitionInterface $field_definition) {
   ...
   +      $values = array(
   +        'entity_type' => $field_definition->getTargetEntityTypeId(),
   

   this is totally wrong

2. +++ b/core/modules/comment/src/Tests/CommentItemTest.php
   @@ -0,0 +1,89 @@
   +    $entity = entity_create('entity_test');
   +    $entity->comment->generateSampleItems();
   

   that's enough to make sure other properties of the field populated

3. +++ b/core/modules/comment/src/Tests/CommentItemTest.php
   @@ -0,0 +1,89 @@
   +      $entity->save();
   

   any reason to save?

@Manuel Garcia
note patch #3 from devel_generate issue fix only devel_generate tests

@andypost
i agree with you #7 should enough to make devel work but probably we needs to extend generateSampleValue with other fields from CommentItem::propertyDefinitions.. and I think we still need test coverage for CommentItemTest

So here's a test and test+patch

No reason to extend because only status property is stored in field, others are populated on load

oh, previous patches are wrong

RTBC for me

+++ b/core/modules/comment/src/Plugin/Field/FieldType/CommentItem.php
@@ -193,4 +194,13 @@ public function storageSettingsForm(array &$form, FormStateInterface $form_state
+      'status' => mt_rand(CommentItemInterface::HIDDEN, CommentItemInterface::OPEN),

This assumes ordered values which might change in the future. Better use something inline with

$statusses = array(CommentItemInterface::HIDDEN, CommentItemInterface::OPEN);
$status = $statusses[mt_rand(0, count($statusses)-1];

@clemens.tolboom Nice catch! Fixed

RTBC, works great!

Major because generating content is crucial for proper benchmarking.

Are we going to address the other properties in a followup or in this issue? I would have though generating content with comments is crucial for proper benchmarking?

This needs a summary update explaining what we do with

CommentItem::propertyDefinitions

@alexpott comment field have only one status property, other properties are populated in runtime and there's #2304939: Stop loading comment statistics into entity object

Fixed summary.

Committed 0972ecb and pushed to 8.0.x. Thanks!