Needs review
Project:
KeyCAPTCHA
Version:
7.x-1.3
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 Feb 2015 at 12:18 UTC
Updated:
15 Aug 2016 at 14:36 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
shkiper commentedI've made this module compatible with Drupal 8 stable version. Here is my patch
Comment #2
naveenvalechaextra tabs here.
Remove it. its not needed.
Add a new line after use statements. i.e. b/c use statements and description.
This is better "Keycaptcha Configuration form"
use $this->config here instead of static functions.
use inejctable t here i.e. $this->t
same as above. use $this->config
Comment #3
naveenvalecha@mvladykin,
Any plans to release the d8 development snapshot ?
Comment #4
shkiper commentedHi @naveenvalecha. Thank you for your review. I fixed issues 1-7. Here is my new patch
Comment #5
naveenvalechaDefine these permissions in .permissions.yml file
Also change all the workds in the permission key to lowercase.
What this is for ?
user $config->get directly here.
I'll test it thoroughly sometime later.
Comment #6
shkiper commentedHi @naveenvalecha.
1. This is permissions from CAPTCHA module.
2. Copy/paste mistake, deleted.
3. Done