Found in #2216271.

AssertNoLink() has no index (the 0). so we're using 0 as the message, and the message as the group.

CommentFileSizeAuthor
fixAssertNoLinks.patch1.72 KBlokapujya
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lokapujya’s picture

lokapujya
Primary language English
Location Boston
CreditAttribution: lokapujya commented
Title: Fix assertNoLinks that should not have an index param » Fix assertNoLinks() that should not have an index parameter.
Priority: Normal » Minor

Changing to minor since the bug is only when looking at test results.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Good catches!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, fixAssertNoLinks.patch, failed testing.

Status: Needs work » Needs review

lokapujya queued fixAssertNoLinks.patch for re-testing.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
CreditAttribution: lokapujya commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice catch.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 4cdd4d1 on 8.0.x 
    Issue #2421531 by lokapujya: Fix assertNoLinks() that should not have an...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.