Problem/Motivation

Taxonomy modules css is only visual elements, this should be in theme.css not in module.css

background colors and borders are not essential for a module

.taxonomy-term-preview {
  background-color: #eee;
}
.taxonomy-term-divider-top {
  border-bottom: none;
}
.taxonomy-term-divider-bottom {
  border-top: 1px dotted #ccc;
}

Proposed resolution

rename taxonomy.module.css to taxonmy.theme.css

Remaining tasks

Testing this patch.

The module should still be functional and accessible without the modulename.theme.css file. To test this, remove the theme.css files and inspect the relevant pages in Stark.

User interface changes

API changes

CommentFileSizeAuthor
#6 taxonomy.png59.53 KBrteijeiro
#4 taxonomy-module-theme-css-4.patch680 byteslewisnyman
taxonomy-module-theme-css.diff853 bytesmortendk

Comments

mortendk’s picture

mortendk commented
Status: Active » Needs review
lewisnyman’s picture

lewisnyman
he/him
commented
Issue summary: View changes
mortendk’s picture

mortendk commented

ok why isnt my patch removing the old file ?

lewisnyman’s picture

lewisnyman
he/him
commented
StatusFileSize
new taxonomy-module-theme-css-4.patch680 bytes

@mortendk This is how I do it:

cp oldfile.css newfile.css
git add newfile.css
git rm oldfile.css
git commit -m "Issue number"
git diff HEAD~1 > issue.patch
idebr’s picture

idebr commented

@mortendk You may have to add a line to your git configuration, see https://www.drupal.org/documentation/git/configure

Optimize diffs for renamed and copied files

[diff]
  renames = copies
rteijeiro’s picture

rteijeiro commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new taxonomy.png59.53 KB

It looks good and still works when removing CSS.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Templates are not frozen in beta. Committed fd8672a and pushed to 8.0.x. Thanks!

  • alexpott committed fd8672a on 8.0.x 
    Issue #2421391 by mortendk, LewisNyman, rteijeiro: taxonomy.modules.css...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.