Problem/Motivation

Undefined variables in core/modules/locale/src/StringBase.php

Proposed resolution

Fix it.

Remaining tasks

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#6 2421133-string-base-6.patch2.54 KBpenyaskito
#6 2421133-string-base-6.only-test.patch1.22 KBpenyaskito
#6 2421133-string-base.interdiff.1-6.txt2.42 KBpenyaskito
#1 2421133-1.patch865 bytespenyaskito

Comments

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
Issue tags: +Novice, +language-base, +sprint, +D8MI
StatusFileSize
new 2421133-1.patch865 bytes

Status: Needs review » Needs work

The last submitted patch, 1: 2421133-1.patch, failed testing.

Status: Needs work » Needs review

Gábor Hojtsy queued 1: 2421133-1.patch for re-testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: +Needs tests

We seem to be lacking test coverage for these then?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review
Issue tags: -Novice, -Needs tests
StatusFileSize
new 2421133-string-base.interdiff.1-6.txt2.42 KB
new 2421133-string-base-6.only-test.patch1.22 KB
new 2421133-string-base-6.patch2.54 KB

The last submitted patch, 6: 2421133-string-base-6.only-test.patch, failed testing.

penyaskito queued 6: 2421133-string-base-6.only-test.patch for re-testing.

The last submitted patch, 6: 2421133-string-base-6.only-test.patch, failed testing.

penyaskito queued 6: 2421133-string-base-6.only-test.patch for re-testing.

The last submitted patch, 6: 2421133-string-base-6.only-test.patch, failed testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 2524d8d and pushed to 8.0.x. Thanks!

  • alexpott committed 2524d8d on 8.0.x 
    Issue #2421133 by penyaskito: Undefined variables in core/modules/locale...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint

Yay, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.