Problem/Motivation

The typography.css file has been deleted in #2398447: Remove the "typography" CSS file in Bartik, but references to the file remain in bartik.info.yml and bartik.libraries.yml. This results in 404 requests when a page with the Bartik theme is visited.

Proposed resolution

Remove typography.css from Bartik libraries and info yml files

Remaining tasks

  1. Write a patch
  2. Review

User interface changes

None

API changes

None

CommentFileSizeAuthor
#3 interdiff-3-1.txt863 bytesidebr
#3 2420223-3.patch1.68 KBidebr
#1 2420223-1.patch860 bytesidebr

Comments

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new 2420223-1.patch860 bytes

Status: Needs review » Needs work

The last submitted patch, 1: 2420223-1.patch, failed testing.

idebr’s picture

idebr commented
Status: Needs work » Needs review
StatusFileSize
new 2420223-3.patch1.68 KB
new interdiff-3-1.txt863 bytes

This patch removes the reference to typography.css in the CKEditorTest as well.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Tested in simplytest that there are not any other related errors logged in Chrome console.
I grep in my working copy and didn't found more references in bartik.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I should have caught this alexpott--

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 6f34dff and pushed to 8.0.x. Thanks!

  • alexpott committed 6f34dff on 8.0.x 
    Issue #2420223 by idebr: Remove typography.css from Bartik libraries and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.