This a response to a closing comment

https://www.drupal.org/node/2418567#comment-9584237

We do have a gazillion doc issues in views - and a systematic approach is always better....BUT I don't want to fix all things in one issue..

So this is a half way house approach between my flawed piecemeal approach and a unreviewable mega patch.

The method behind my madness is find all classes that extend FieldPluginBase

add a @inheritdoc where appropriate, ignore all the other doc issue I can see and call it day. ( it took me about 20 mins )

I do appreciate I am soaking up reviewer and core committers time, but once you see the repeating pattern
I hope this can be reviewed in the blink of an eye.

Compact beta evaluation: This is unfrozen - just API docs and non-controversial as well.

CommentFileSizeAuthor
systematic-0.patch27.31 KBmartin107

Comments

martin107’s picture

martin107 commented
Status: Active » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Title: A more systematic approach to fixing a type hinting issue. » Add inheritdoc to FieldPluginBase extending classes
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

We actually have a meta issue for the type hinting subject:
#1800046: [META] Add missing type hinting to core docblocks, fix Drupal.Commenting.FunctionComment.Missing*

But ... this patch isn't about type hinting, and yes it can be reviewed quickly, so I did! It is good.

Changed title and added beta eval.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Great!

Committed and pushed to 8.0.x. Thanks!

  • webchick committed da571c5 on 8.0.x 
    Issue #2419943 by martin107: Add inheritdoc to FieldPluginBase extending...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.