Problem/Motivation

The test coverage for URL::fromUri() does not yet include explicit coverage for various types of URL tokens used in core. Additionally, the tested patterns are not documented.

Proposed resolution

Document the tested patterns and add a few.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Unfrozen changes Unfrozen because it only changes unit tests
Disruption No disruption.

Remaining tasks

Needs review.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
uri-test-coverage.patch1.51 KBxjm

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Expand and document test coverage for URL::fromUri() » Expand and document test coverage in UrlTest and UnroutedUrlTest
Assigned: Unassigned » tim.plunkett

Expanding this a bit. It will conflict with #2418139: Add a toUriString method to Url class and add a route: scheme so once I am done I will postpone on that.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Expand and document test coverage in UrlTest and UnroutedUrlTest » Expand and document test coverage in UnroutedUrlTest
Assigned: tim.plunkett » Unassigned

@tim.plunkett and I discussed this and the UnroutedUrlTest changes don't conflict, so we can get those in first and put the ones that need postponing in another issue.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

+1 for better docs and more coverage. I'll link to the issue for expanding UrlTest shortly.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Oops, missed this one.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 9fe522a on 8.0.x 
    Issue #2418169 by xjm: Expand and document test coverage in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.